Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backblaze: 2.0.2 -> 2.1.0 #105390

Closed
wants to merge 3 commits into from
Closed

backblaze: 2.0.2 -> 2.1.0 #105390

wants to merge 3 commits into from

Conversation

@freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 29, 2020

Motivation for this change

Update b2 tool to latest release and some deps

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
freezeboy added 2 commits Nov 29, 2020
Upstream renamed the package class-registry into phx-class-registry.

Support for python2 has been dropped
checkPhase = ''
nosetests
'';
# Nosetests/pytest are failing on this release
Copy link
Member

@ryantm ryantm Nov 29, 2020

You should say which release, so we don't keep this forever.

@freezeboy freezeboy force-pushed the update-backblaze branch from 3bada29 to daf4944 Nov 29, 2020
# Nosetests/pytest are failing on release 2.1.0
doCheck = false;
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 30, 2020

Suggested change
# Nosetests/pytest are failing on release 2.1.0
doCheck = false;
disabledTests = [
"test_files_headers"
"test_integration"
];

};

propagatedBuildInputs = with python3Packages; [
arrow
b2sdk
class-registry
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 30, 2020

Suggested change
class-registry
phx-class-registry

# Tests currently failing.
doCheck = false;
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 30, 2020

Suggested change
# Tests currently failing.
doCheck = false;
disabledTests = [
"test_branding"
"test_happy_path"
"test_len"
];

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

And there is already #104807 which does not fail ofborg. Closing this one. Next time please do a quick search.

@freezeboy freezeboy deleted the update-backblaze branch Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants