Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r2mod_cli: init at 1.0.5 #105391

Merged
merged 2 commits into from Dec 20, 2020
Merged

r2mod_cli: init at 1.0.5 #105391

merged 2 commits into from Dec 20, 2020

Conversation

@reedrw
Copy link
Contributor

@reedrw reedrw commented Nov 29, 2020

Motivation for this change

add r2mod_cli, a Risk of Rain 2 mod manager written in Bash.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/games/r2mod_cli/default.nix Outdated Show resolved Hide resolved
pkgs/games/r2mod_cli/default.nix Outdated Show resolved Hide resolved
@rissson
Copy link
Member

@rissson rissson commented Nov 29, 2020

Result of nixpkgs-review pr 105391 1

1 package built:
  • r2mod_cli

pkgs/games/r2mod_cli/default.nix Outdated Show resolved Hide resolved
pkgs/games/r2mod_cli/default.nix Outdated Show resolved Hide resolved
pkgs/games/r2mod_cli/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105391 run on x86_64-linux 1

1 package built:
  • r2mod_cli

@reedrw reedrw requested a review from SuperSandro2000 Nov 30, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 1, 2020

these derivations will be built:
  /nix/store/dcn70izlrvs3157wgrh14905nx3i9jsa-r2mod_cli-1.0.5.drv
building '/nix/store/dcn70izlrvs3157wgrh14905nx3i9jsa-r2mod_cli-1.0.5.drv'...
unpacking sources
unpacking source archive /nix/store/iqlfiv6dbgn86c87h97fijbf6lhv79w5-source
source root is source
patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/9yapmh2s4z7dz07zdpd626329bcqh1p0-bash-4.4-p23/bin/bash
install -d "/usr/bin"
install: cannot create directory '/usr': Permission denied
make: *** [Makefile:5: install] Error 1
builder for '/nix/store/dcn70izlrvs3157wgrh14905nx3i9jsa-r2mod_cli-1.0.5.drv' failed with exit code 2
error: build of '/nix/store/dcn70izlrvs3157wgrh14905nx3i9jsa-r2mod_cli-1.0.5.drv' failed

@reedrw
Copy link
Contributor Author

@reedrw reedrw commented Dec 1, 2020

This is happening because it's running the makefile from the source directory (which only contains an install step) in the build phase. What's wrong with just overwriting phases?

@reedrw
Copy link
Contributor Author

@reedrw reedrw commented Dec 9, 2020

@SuperSandro2000 I assume the more idiomatic way to do it is to use make flags?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 11, 2020

What's wrong with just overwriting phases?

Some hooks expect phases to contain certain code and overwriting them breaks the hooks.

pkgs/games/r2mod_cli/default.nix Outdated Show resolved Hide resolved
@reedrw reedrw requested a review from SuperSandro2000 Dec 12, 2020
@reedrw reedrw requested a review from SuperSandro2000 Dec 14, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 20, 2020

Result of nixpkgs-review pr 105391 run on x86_64-linux 1

1 package built:
  • r2mod_cli

@SuperSandro2000 SuperSandro2000 merged commit e98df3d into NixOS:master Dec 20, 2020
19 checks passed
@reedrw reedrw deleted the r2mod branch Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants