Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libff: init at 1.0.0 #105400

merged 1 commit into from Nov 30, 2020

libff: init at 1.0.0 #105400

merged 1 commit into from Nov 30, 2020


Copy link

@arcz arcz commented Nov 29, 2020

Motivation for this change

Split out from #105298

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@cdepillabout cdepillabout commented Nov 30, 2020

This looks good, compiles on x86_64, and reviewed by @SuperSandro2000 in #105298

@cdepillabout cdepillabout merged commit a2b278f into NixOS:master Nov 30, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants