Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoc: add minimal variant for Python 3 #105405

Closed
wants to merge 1 commit into from

Conversation

@lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 29, 2020

Motivation for this change

Trying to remove things from the minimal ISO that still rely on Python 2. #105392

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lukegb lukegb force-pushed the r13y-yaks-asciidoc branch from 81a5979 to 47fc343 Nov 30, 2020
@ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 30, 2020

How does this relate to #102398?

@lukegb
Copy link
Contributor Author

@lukegb lukegb commented Nov 30, 2020

Hrm, if #102398 is near landing that's probably a better approach - I just didn't want to test all the additional plugins.

@lukegb lukegb closed this Nov 30, 2020
@lukegb lukegb deleted the r13y-yaks-asciidoc branch Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants