Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bwa: expand supported platforms #105409

Merged
merged 1 commit into from Nov 30, 2020
Merged

bwa: expand supported platforms #105409

merged 1 commit into from Nov 30, 2020

Conversation

@jbedo
Copy link
Contributor

@jbedo jbedo commented Nov 29, 2020

Motivation for this change

BWA works across more platforms than just GCC on linux. This patch removes the enforced gcc line of the Makefile, allowing other stdenvs with non-gcc compilers to build, expanding support to other platforms.

@luispedro

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@luispedro luispedro left a comment

LGTM

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

Result of nixpkgs-review pr 105409 1

2 packages marked as broken and skipped:
  • tebreak
  • truvari
3 packages built:
  • bwa
  • python37Packages.bwapy
  • python38Packages.bwapy

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

Result of nixpkgs-review pr 105409 run on x86_64-linux 1

5 packages built:
  • bwa
  • python37Packages.bwapy
  • python38Packages.bwapy
  • tebreak
  • truvari

@SuperSandro2000 SuperSandro2000 merged commit cc10a82 into NixOS:master Nov 30, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants