git: make manual reproducible #105498
Merged
git: make manual reproducible #105498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should target staging, as it causes a mass rebuild. No further comments, does not seem like this change would cause breakage. |
prusnak
approved these changes
Nov 30, 2020
SuperSandro2000
approved these changes
Dec 1, 2020
andir
reviewed
Dec 1, 2020
veprbl
reviewed
Dec 1, 2020
pkgs/applications/version-management/git-and-tools/git/default.nix
Outdated
Show resolved
Hide resolved
This makes the git HTML manual reproducible. It also removes the `git.info` manual, since this one is basically entirely broken anyway. This likely happened when we migrated from asciidoc to asciidoctor in NixOS#102020. I don't suggest going back to asciidoc: that would re-introduce a python2 dependency and another reproducibility issue with the HTML docs. Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
raboof
force-pushed
the
git-reproducible-docs
branch
from
ca14c75
to
91099b0
Compare
prusnak
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This makes the git HTML manual reproducible.
It also removes the
git.infomanual, since this one isbasically entirely broken anyway. This likely happened
when we migrated from asciidoc to asciidoctor in #102020.
I don't suggest going back to asciidoc: that would
re-introduce a python2 dependency and another
reproducibility issue with the HTML docs.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)