compress-man-pages: symlink compressed manpages deterministically #105818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
approved these changes
Dec 3, 2020
For example graphviz has chained symlinked manpages: dot2gxl.1 is a symlink to gv2gxl.1 which is a symlink to gxl2gv.1 The second loop replaces each non-compressed symlink to a compressed symlink. The target is determined with 'readlink -f', which follows links recursively until the first name that is not a link (so either the 'target name' or the first 'dangling' symlink). This means that if the loop converted dot2gxl.1 before converting gv2gxl.1 it would add a symlink `dot2gxl.1.gz->gxl2gv.1.gz`. When it converted gv2gxl.1 first, it would then add a `dot2gxl.1.gz->gv2gxl.1.gz` symlink. Both are 'correct', but it's weird the result depends on the order in which 'find' returns the files. This PR makes the behaviour deterministic. fixes NixOS#104708
raboof
force-pushed
the
symlink-compressed-manpages-deterministically
branch
from
dcbc381
to
777cb35
Compare
prusnak
approved these changes
Dec 7, 2020
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
@FRidh just wanted to inform you about this if you see some random errors on staging with man pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
For example graphviz has chained symlinked manpages: dot2gxl.1 is
a symlink to gv2gxl.1 which is a symlink to gxl2gv.1
The second loop replaces each non-compressed symlink to a compressed
symlink. The target is determined with 'readlink -f', which follows
links recursively until the first name that is not a link (so either
the 'target name' or the first 'dangling' symlink).
This means that if the loop converted dot2gxl.1 before converting
gv2gxl.1 it would add a symlink
dot2gxl.1.gz->gxl2gv.1.gz. Whenit converted gv2gxl.1 first, it would then add a
dot2gxl.1.gz->gv2gxl.1.gzsymlink.Both are 'correct', but it's weird the result depends on the order
in which 'find' returns the files. This PR makes the behaviour
deterministic.
fixes #104708
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)