Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pillow: Add libxcb support, convert to generic; pythonPackages.pillow-simd: Init at 7.0.0.post3 #108098

Merged
merged 4 commits into from Feb 1, 2021

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 1, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000 SuperSandro2000 requested review from FRidh and jonringer as code owners Jan 1, 2021
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Jan 1, 2021

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108098 run on x86_64-linux 1

3 packages built:
  • python37Packages.pillow-simd
  • python38Packages.pillow-simd
  • python39Packages.pillow-simd
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Jan 1, 2021

Result of nixpkgs-review pr 108098 run on x86_64-darwin 1

3 packages failed to build:
  • python37Packages.pillow-simd
  • python38Packages.pillow-simd
  • python39Packages.pillow-simd
@lukegb
Copy link
Contributor

@lukegb lukegb commented Jan 1, 2021

Given this is intended to be compatible with upstream, I can't help but wonder if a generic.nix-approach would be better to avoid duplicating the package specification between pillow and pillow-simd, but that's probably more a question for the pillow maintainers, since it pushes maintenance onto them a bit.

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Jan 1, 2021

/rebase-staging

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Jan 1, 2021

Given this is intended to be compatible with upstream, I can't help but wonder if a generic.nix-approach would be better to avoid duplicating the package specification between pillow and pillow-simd, but that's probably more a question for the pillow maintainers, since it pushes maintenance onto them a bit.

The code between pillow 6, 8 and simd is almost identically and I just went ahead and created a generic.nix and added me as a maintainer.

@github-actions github-actions bot changed the base branch from master to staging Jan 1, 2021
@github-actions github-actions bot force-pushed the SuperSandro2000:pillow-simd branch from 5375f5c to 04865d8 Jan 1, 2021
@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:pillow-simd branch from 04865d8 to 496ab28 Jan 1, 2021
@SuperSandro2000 SuperSandro2000 changed the title pythonPackages.pillow-simd: Init at 7.0.0.post3 pythonPackages.pillow: Add libxcb support, convert to generic; pythonPackages.pillow-simd: Init at 7.0.0.post3 Jan 1, 2021
@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:pillow-simd branch from 496ab28 to 36ea46f Jan 1, 2021
@ofborg ofborg bot requested review from cillianderoiste and prikhi Jan 1, 2021
@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:pillow-simd branch from 36ea46f to 7f21665 Jan 6, 2021
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Jan 6, 2021

/rebase-staging

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Jan 6, 2021

I thought I could avoid the staging here but whatever.

@github-actions github-actions bot changed the base branch from master to staging Jan 6, 2021
@github-actions github-actions bot force-pushed the SuperSandro2000:pillow-simd branch from bfdc3d7 to 4e40976 Jan 6, 2021
@roberth
Copy link
Contributor

@roberth roberth commented Jan 6, 2021

Please mark PRs as draft while rebasing.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Jan 6, 2021

Please mark PRs as draft while rebasing.

@roberth rebases are now automated via github actions.

@roberth
Copy link
Contributor

@roberth roberth commented Jan 6, 2021

@Mic92 I was referring to this manual rebase #108098 (comment)

automated via github actions.

Judging by the timeline here and the workflow definition, I don't see a reason why it wouldn't suffer from the same problem, though I'll give it the benefit of the doubt until I see it happen again. The spam issue didn't occur with all rebases after all.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Jan 6, 2021

@Mic92 I was referring to this manual rebase #108098 (comment)

automated via github actions.

Judging by the timeline here and the workflow definition, I don't see a reason why it wouldn't suffer from the same problem, though I'll give it the benefit of the doubt until I see it happen again. The spam issue didn't occur with all rebases after all.

Fair enough. I only saw the bot one.

@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:pillow-simd branch from 4e40976 to a7e8bb1 Jan 30, 2021
@SuperSandro2000 SuperSandro2000 requested a review from thoughtpolice as a code owner Jan 30, 2021
@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:pillow-simd branch from a7e8bb1 to 3d4d159 Jan 30, 2021
@SuperSandro2000

This comment has been hidden.

@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:pillow-simd branch 2 times, most recently from ba9c01f to a619767 Jan 31, 2021
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Jan 31, 2021

@ofborg eval

@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:pillow-simd branch from a619767 to aa1aab7 Jan 31, 2021
@SuperSandro2000 SuperSandro2000 merged commit 3796e38 into NixOS:staging Feb 1, 2021
18 checks passed
18 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa1aab7"; rev="aa1aab7c7fc22ff6a0ddc236a106172bd2d291df"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa1aab7"; rev="aa1aab7c7fc22ff6a0ddc236a106172bd2d291df"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa1aab7"; rev="aa1aab7c7fc22ff6a0ddc236a106172bd2d291df"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa1aab7"; rev="aa1aab7c7fc22ff6a0ddc236a106172bd2d291df"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa1aab7"; rev="aa1aab7c7fc22ff6a0ddc236a106172bd2d291df"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa1aab7"; rev="aa1aab7c7fc22ff6a0ddc236a106172bd2d291df"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa1aab7"; rev="aa1aab7c7fc22ff6a0ddc236a106172bd2d291df"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ofborg-eval-started Evaluation started
Details
@SuperSandro2000 SuperSandro2000 deleted the SuperSandro2000:pillow-simd branch Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment