Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: add vim_darwin package for macOS #108109

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Conversation

gurjeet
Copy link
Contributor

@gurjeet gurjeet commented Jan 1, 2021

The default Vim package does not have some advanced features like
python3, hence we need to use the vim_configurable package and customize
it to provide a fuller build of Vim on macOS.

If one were to use the vim_configurable package as is, the user does not
get the nice OS integration features like copy-pasting from system
clipboard.

Motivation for this change

Get a fully-featured (python etc.) Vim on macOS, along with the ability to
copy/paste from/to macOS clipboard.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The default Vim package does not have some advanced features like
python3, hence we need to use the vim_configurable package and customize
it to provide a fuller build of Vim on macOS.

If one were to use the vim_configurable package as is, the user does not
get the nice OS integration features like copy-pasting from system
clipboard.
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108109 run on x86_64-darwin 1

1 package built:
  • vim_darwin

@gurjeet
Copy link
Contributor Author

gurjeet commented Jan 1, 2021

@prusnak @SuperSandro2000 thanks for the feedback! I have added a commit based on your feedback. Please review.

@gurjeet
Copy link
Contributor Author

gurjeet commented Jan 4, 2021

@prusnak, @SuperSandro2000, a gentle reminder to follow-up. Please let me know if I need to do something more, or ping someone else to get this merged and closed.

@prusnak
Copy link
Member

prusnak commented Jan 4, 2021

Please let me know if I need to do something more, or ping someone else to get this merged and closed.

I think you should ping vim maintainers

@gurjeet
Copy link
Contributor Author

gurjeet commented Jan 5, 2021

Thanks for the pointer @prusnak!

@lovek323 @equirosa, I see you listed as the maintainers in vim/common.nix. Can you please review this small PR and see if it's ready for merge.

Copy link
Member

@lovek323 lovek323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gurjeet
Copy link
Contributor Author

gurjeet commented Jan 25, 2021

A gentle reminder for merging the PR. /cc @equirosa

@SuperSandro2000 SuperSandro2000 changed the title Vim: Added vim_darwin package for macOS vim: add vim_darwin package for macOS Jan 25, 2021
@SuperSandro2000 SuperSandro2000 merged commit 891f607 into NixOS:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants