Skip to content

/ nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reaper: 6.12c -> 6.19 #109293

Merged
merged 4 commits into from Jan 14, 2021
Merged

reaper: 6.12c -> 6.19 #109293

merged 4 commits into from Jan 14, 2021

Conversation

@ilian
Copy link
Member

@ilian ilian commented Jan 13, 2021

Motivation for this change

Update Reaper to version 6.19.

Changelog: https://www.reaper.fm/whatsnew.txt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ilian ilian requested a review from Infinisil Jan 13, 2021
@ofborg ofborg bot requested a review from jfrankenau Jan 13, 2021
@hugolgst
hugolgst reviewed Jan 13, 2021
View changes
Copy link
Member

@hugolgst hugolgst left a comment

I'd suggest you split c05a9b2 into:

  • maintainers: add ilian
  • bonzomatic: update maintainers
  • rpcs3: update maintainers

Otherwise, the package update looks good to me.
@hugolgst
Copy link
Member

@hugolgst hugolgst commented Jan 13, 2021

Result of nixpkgs-review pr 109293 1

1 package built:
  • reaper
ilian added 4 commits Jan 13, 2021
@ilian
maintainers: update username nocent -> ilian
696d91d 
My GitHub ID remains 25505957 as confirmed by the GitHub API:
https://api.github.com/users/ilian
@ilian
bonzomatic: update maintainers
e10bf33
@ilian
rpcs3: update maintainers
e05cbb8
@ilian
reaper: 6.12c -> 6.19
Loading status checks…
72b730c
@ilian ilian force-pushed the ilian:u/reaper branch from 5fcb6a7 to 72b730c Jan 13, 2021
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 14, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109293 run on x86_64-linux 1

1 package built:
  • reaper
@Infinisil
Infinisil approved these changes Jan 14, 2021
View changes
Copy link
Member

@Infinisil Infinisil left a comment •
edited

Looking good! 😀
@Infinisil Infinisil merged commit 7ddb893 into NixOS:master Jan 14, 2021
19 checks passed
19 checks passed
tests
Details
action
Details
bonzomatic, bonzomatic.passthru.tests, reaper, reaper.passthru.tests, rpcs3, rpcs3.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
bonzomatic, bonzomatic.passthru.tests, reaper, reaper.passthru.tests, rpcs3, rpcs3.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72b730c"; rev="72b730c5e97a76633129a7212c0e1ce34e4d50c1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72b730c"; rev="72b730c5e97a76633129a7212c0e1ce34e4d50c1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72b730c"; rev="72b730c5e97a76633129a7212c0e1ce34e4d50c1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72b730c"; rev="72b730c5e97a76633129a7212c0e1ce34e4d50c1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72b730c"; rev="72b730c5e97a76633129a7212c0e1ce34e4d50c1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72b730c"; rev="72b730c5e97a76633129a7212c0e1ce34e4d50c1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72b730c"; rev="72b730c5e97a76633129a7212c0e1ce34e4d50c1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ilian
Copy link
Member Author

@ilian ilian commented Jan 14, 2021

Thanks for the fast review 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst

@Infinisil Infinisil

@jfrankenau jfrankenau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@ilian @hugolgst @SuperSandro2000 @Infinisil
You can’t perform that action at this time.