Skip to content

/ nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.mathcomp-abel: init at 1.0.0 #109330

Merged
merged 1 commit into from Jan 15, 2021
Merged

coqPackages.mathcomp-abel: init at 1.0.0 #109330

merged 1 commit into from Jan 15, 2021
+24 −0

Conversation

@CohenCyril
Copy link
Contributor

@CohenCyril CohenCyril commented Jan 14, 2021

Motivation for this change

Adding Coq proof of Abel-Galois and Abel-Ruffini Theorems

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
SuperSandro2000 reviewed Jan 14, 2021
View changes
pkgs/development/coq-modules/mathcomp-abel/default.nix Outdated Show resolved Hide resolved
pkgs/development/coq-modules/mathcomp-abel/default.nix Outdated Show resolved Hide resolved
pkgs/development/coq-modules/mathcomp-abel/default.nix Outdated Show resolved Hide resolved
@CohenCyril CohenCyril force-pushed the CohenCyril:mathcomp-abel branch 2 times, most recently from 71120b1 to 5dd551b Jan 14, 2021
@CohenCyril
Copy link
Contributor Author

@CohenCyril CohenCyril commented Jan 14, 2021

@GrahamcOfBorg coqPackages_8_10.mathcomp-abel coqPackages.mathcomp-abel coqPackages_8_12.mathcomp-abel coqPackages_8_13.mathcomp-abel
@CohenCyril
Copy link
Contributor Author

@CohenCyril CohenCyril commented Jan 14, 2021

@GrahamcOfBorg build coqPackages_8_10.mathcomp-abel coqPackages.mathcomp-abel coqPackages_8_12.mathcomp-abel coqPackages_8_13.mathcomp-abel
@CohenCyril
coqPackages.mathcomp-abel: init at 1.0.0
Loading status checks…
f06be1b
@CohenCyril CohenCyril force-pushed the CohenCyril:mathcomp-abel branch from 5dd551b to f06be1b Jan 14, 2021
@CohenCyril
Copy link
Contributor Author

@CohenCyril CohenCyril commented Jan 14, 2021

@GrahamcOfBorg build coqPackages_8_10.mathcomp-abel coqPackages.mathcomp-abel coqPackages_8_12.mathcomp-abel coqPackages_8_13.mathcomp-abel
@SuperSandro2000 SuperSandro2000 merged commit 65aca46 into NixOS:master Jan 15, 2021
18 checks passed
18 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
coqPackages.mathcomp-abel, coqPackages_8_10.mathcomp-abel, coqPackages_8_12.mathcomp-abel, coqPackages_8_13.mathcomp-abel on aarch64-linux Success
Details
coqPackages.mathcomp-abel, coqPackages_8_10.mathcomp-abel, coqPackages_8_12.mathcomp-abel, coqPackages_8_13.mathcomp-abel on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f06be1b"; rev="f06be1bcf9582015dcfdfad84fa77279ff54009f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f06be1b"; rev="f06be1bcf9582015dcfdfad84fa77279ff54009f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f06be1b"; rev="f06be1bcf9582015dcfdfad84fa77279ff54009f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f06be1b"; rev="f06be1bcf9582015dcfdfad84fa77279ff54009f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f06be1b"; rev="f06be1bcf9582015dcfdfad84fa77279ff54009f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f06be1b"; rev="f06be1bcf9582015dcfdfad84fa77279ff54009f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f06be1b"; rev="f06be1bcf9582015dcfdfad84fa77279ff54009f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 15, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109330 run on x86_64-linux 1

1 package built:
  • coqPackages.mathcomp-abel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@CohenCyril @SuperSandro2000
You can’t perform that action at this time.