Skip to content

/ nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nodejs: 10.22.1 -> 10.23.1, 12.18.4 -> 12.20.1, 14.9.0 -> 14.15.4 #109336

Merged
merged 5 commits into from Jan 14, 2021
Merged

[20.09] nodejs: 10.22.1 -> 10.23.1, 12.18.4 -> 12.20.1, 14.9.0 -> 14.15.4 #109336

merged 5 commits into from Jan 14, 2021

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Jan 14, 2021

Motivation for this change

https://nodejs.org/en/blog/vulnerability/november-2020-security-releases/
https://nodejs.org/en/blog/vulnerability/january-2021-security-releases/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
marsam added 5 commits Sep 8, 2020
@marsam
libuv: 1.38.1 -> 1.39.0
4a600d8 
(cherry picked from commit 90c5f2f)
@marsam
libuv: 1.39.0 -> 1.40.0
4da0df1 
(cherry picked from commit 13eb51b)
@marsam
nodejs-10_x: 10.22.1 -> 10.23.1
9530a77
@marsam
nodejs-12_x: 12.18.4 -> 12.20.1
4dc5d36
@marsam
nodejs-14_x: 14.9.0 -> 14.15.4
Loading status checks…
af2e868
@marsam marsam changed the title [20.09] nodejs: 10.22.1 -> 10.23.1, 12.18.4 -> 12.20.1, 14.9.0 -> 14.15.4 af2e868 [20.09] nodejs: 10.22.1 -> 10.23.1, 12.18.4 -> 12.20.1, 14.9.0 -> 14.15.4 Jan 14, 2021
@ofborg ofborg bot requested a review from cstrahan Jan 14, 2021
@marsam marsam merged commit 7172fda into NixOS:staging-20.09 Jan 14, 2021
18 of 19 checks passed
18 of 19 checks passed
action
Details
libuv, libuv.passthru.tests, nodejs-10_x, nodejs-10_x.passthru.tests, nodejs-12_x, nodejs-12_x.passthru.tests, nodejs-14_x, nodejs-14_x.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="af2e868"; rev="af2e868f310a8718facbb541701fd197fea6bd8f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="af2e868"; rev="af2e868f310a8718facbb541701fd197fea6bd8f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="af2e868"; rev="af2e868f310a8718facbb541701fd197fea6bd8f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="af2e868"; rev="af2e868f310a8718facbb541701fd197fea6bd8f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="af2e868"; rev="af2e868f310a8718facbb541701fd197fea6bd8f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="af2e868"; rev="af2e868f310a8718facbb541701fd197fea6bd8f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="af2e868"; rev="af2e868f310a8718facbb541701fd197fea6bd8f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libuv, libuv.passthru.tests, nodejs-10_x, nodejs-10_x.passthru.tests, nodejs-12_x, nodejs-12_x.passthru.tests, nodejs-14_x, nodejs-14_x.passthru.tests on aarch64-linux Success
Details
libuv, libuv.passthru.tests, nodejs-10_x, nodejs-10_x.passthru.tests, nodejs-12_x, nodejs-12_x.passthru.tests, nodejs-14_x, nodejs-14_x.passthru.tests on x86_64-linux Success
Details
@marsam marsam deleted the marsam:backport-nodejs-20.09 branch Jan 14, 2021
@marsam marsam mentioned this pull request Jan 14, 2021
Merged
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 5001+ 10.rebuild-darwin: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@marsam
You can’t perform that action at this time.