Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate revision in name for Dhall GitHub packages #109338

Merged
merged 3 commits into from Jan 15, 2021

Conversation

@Gabriel439
Copy link
Contributor

@Gabriel439 Gabriel439 commented Jan 14, 2021

This is a small quality-of-life improvement so that
the package version/revision can be inferred from the
/nix/store path (which is the convention for most of the
Nixpkgs ecosystem).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is a small quality-of-life improvement so that
the package version/revision can be inferred from the
/nix/store path (which is the convention for most of the
Nixpkgs ecosystem).
@Gabriel439
Copy link
Contributor Author

@Gabriel439 Gabriel439 commented Jan 15, 2021

cc: @ehmry

Also, I apologize for the pings. Perhaps you should be a code owner for Dhall stuff so that I don't need to ping you for reviews. I don't really know how the Nixpkgs code review system works

@ehmry
ehmry approved these changes Jan 15, 2021
@Gabriel439 Gabriel439 requested a review from edolstra as a code owner Jan 15, 2021
@ehmry ehmry merged commit df69951 into NixOS:master Jan 15, 2021
2 of 4 checks passed
2 of 4 checks passed
tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval Checking original stdenvs
Details
@ehmry
Copy link
Member

@ehmry ehmry commented Jan 15, 2021

Good idea. No worries about the pings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.