Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsmasq: 2.82 -> 2.83 #109968

Merged
merged 1 commit into from Jan 19, 2021
Merged

dnsmasq: 2.82 -> 2.83 #109968

merged 1 commit into from Jan 19, 2021

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jan 19, 2021

Motivation for this change

https://www.thekelleys.org.uk/dnsmasq/CHANGELOG
https://www.openwall.com/lists/oss-security/2021/01/19/1

This update fixes several CVEs:
CVE-2020-25681
CVE-2020-25682
CVE-2020-25683
CVE-2020-25687
CVE-2020-25684
CVE-2020-25685
CVE-2020-25686

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 19, 2021
@stigtsp stigtsp mentioned this pull request Jan 19, 2021
Merged
10 tasks
@stigtsp stigtsp requested a review from mweinelt January 19, 2021 15:28
@stigtsp stigtsp force-pushed the package/dnsmasq-2.83-staging-next branch from 43eaa5b to 5cdb30a Compare January 19, 2021 15:37
@SuperSandro2000
Copy link
Member

@ofborg eval

@stigtsp stigtsp force-pushed the package/dnsmasq-2.83-staging-next branch from 5cdb30a to cecd2c8 Compare January 19, 2021 19:22
@mweinelt
Copy link
Member

mweinelt commented Jan 19, 2021 •
edited

Related paper: https://www.jsof-tech.com/wp-content/uploads/2021/01/DNSpooq_Technical-Whitepaper.pdf

They say there is a high likelihood of an RCE in the DNSSEC code, so yeah, let's go with staging-next. 👍

❯ nix-build -A dnsmasq
/nix/store/qx5qm0pjgarwjnspxnkny6n2c8qb6ha5-dnsmasq-2.83

@ofborg ofborg bot requested review from edolstra, fpletz and globin January 19, 2021 19:38
@SuperSandro2000
Copy link
Member

@FRidh

@mweinelt mweinelt merged commit c0ca873 into NixOS:staging-next Jan 19, 2021
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@mweinelt mweinelt Awaiting requested review from mweinelt

@edolstra edolstra Awaiting requested review from edolstra

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stigtsp @SuperSandro2000 @mweinelt @erictapen