Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpich: 3.2.2 -> 3.4.1 #111453

Merged
merged 1 commit into from Feb 3, 2021
Merged

mpich: 3.2.2 -> 3.4.1 #111453

merged 1 commit into from Feb 3, 2021

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Jan 31, 2021

Motivation for this change

https://raw.githubusercontent.com/pmodels/mpich/v3.4.1/RELEASE_NOTES
https://raw.githubusercontent.com/pmodels/mpich/v3.4.1/CHANGES

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111453 run on x86_64-linux 1

5 packages built:
  • haskellPackages.mpi-hs
  • haskellPackages.mpi-hs-binary
  • haskellPackages.mpi-hs-cereal
  • haskellPackages.mpi-hs-store
  • mpich

@markuskowa
Copy link
Member Author

@SuperSandro2000 any further comments, or are we ready to merge?

@SuperSandro2000 SuperSandro2000 merged commit dfab15b into NixOS:master Feb 3, 2021
@markuskowa markuskowa deleted the upd-mpich branch February 3, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants