Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rage: skip check if not x86 #111494

Merged
merged 1 commit into from Feb 1, 2021
Merged

rage: skip check if not x86 #111494

merged 1 commit into from Feb 1, 2021

Conversation

@rien
Copy link
Contributor

@rien rien commented Jan 31, 2021

Motivation for this change

This package was failing to build on aarch64 because a development dependency in the check phase is x86 only.

Things done

Set doCheck = true only for x86 systems.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
rage has a dev-dependency which uses x86-only assembly and thus fails
when performing the check phase. This sets `doCheck = false` for systems
which are not x86.
@rien
Copy link
Contributor Author

@rien rien commented Jan 31, 2021

Should I fix the stdenv.lib warnings? And if so: how?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 31, 2021

Should I fix the stdenv.lib warnings? And if so: how?

Already fixed it

@ofborg eval

@ofborg ofborg bot requested review from ryantm and marsam Jan 31, 2021
@grahamc grahamc merged commit b1d651e into NixOS:master Feb 1, 2021
20 checks passed
20 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa86e0a"; rev="aa86e0a7ae8079e7ba269f4556b0a5e3e843ff7c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa86e0a"; rev="aa86e0a7ae8079e7ba269f4556b0a5e3e843ff7c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa86e0a"; rev="aa86e0a7ae8079e7ba269f4556b0a5e3e843ff7c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa86e0a"; rev="aa86e0a7ae8079e7ba269f4556b0a5e3e843ff7c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa86e0a"; rev="aa86e0a7ae8079e7ba269f4556b0a5e3e843ff7c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa86e0a"; rev="aa86e0a7ae8079e7ba269f4556b0a5e3e843ff7c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa86e0a"; rev="aa86e0a7ae8079e7ba269f4556b0a5e3e843ff7c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ofborg-eval-started Evaluation started
Details
rage, rage.passthru.tests on aarch64-linux Success
Details
rage, rage.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants