Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-cli: 0.6.12 -> 0.7.4 #111510

Closed
wants to merge 1 commit into from
Closed

signal-cli: 0.6.12 -> 0.7.4 #111510

wants to merge 1 commit into from

Conversation

@devzero
Copy link
Contributor

@devzero devzero commented Jan 31, 2021

Motivation for this change

Support the newest compatibility and feature set with the signal app.

Things done

updated version number and hash, also had to switch from jre_headless to openjdk11_headless as the newest version has java class files that only run on Java 11 or newer.

  • [ X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ X] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [X ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [ X] Fits CONTRIBUTING.md.
… new java 11 requirement
@@ -1,13 +1,13 @@
{ stdenv, lib, fetchurl, makeWrapper, jre_headless, libmatthew_java, dbus, dbus_java }:
{ stdenv, lib, fetchurl, makeWrapper, openjdk11_headless, libmatthew_java, dbus, dbus_java }:

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Feb 1, 2021
Member

You need to replace all occurrences of jre_headless if this change is intentional.

@devzero devzero closed this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants