Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reckon: 0.6.0 -> 0.7.1 #112292

Merged
merged 1 commit into from Feb 7, 2021
Merged

Conversation

raboof
Copy link
Member

@raboof raboof commented Feb 7, 2021

Motivation for this change

Particularly nice improvements:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
Copy link
Member Author

raboof commented Feb 7, 2021

Result of nixpkgs-review pr 112292 run on x86_64-linux 1

1 package built:
  • reckon

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 112292 at e3c67f05 run on aarch64-linux 1

1 package built:
1 warning produced:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/text/reckon/default.nix:11:3:

       |
    11 |   installPhase = let
       |   ^
    

Particularly nice improvements:
* [fail on unknown account](cantino/reckon#102)
  in interactive mode
* [use - to read from stdin](cantino/reckon#98)
@raboof
Copy link
Member Author

raboof commented Feb 7, 2021

  `installPhase` should probably contain `runHook preInstall` and `runHook postInstall`.

Fair enough, updated (though that was already there before this PR :) )

@ofborg ofborg bot requested a review from nicknovitski February 7, 2021 13:28
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 112292 run on x86_64-linux 1

This is not that useful because it does not validate if you used the right hashes.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112292 run on x86_64-darwin 1

1 package built:
  • reckon

@SuperSandro2000 SuperSandro2000 merged commit f0dcfbc into NixOS:master Feb 7, 2021
@raboof
Copy link
Member Author

raboof commented Feb 8, 2021

Result of nixpkgs-review pr 112292 run on x86_64-linux 1

This is not that useful because it does not validate if you used the right hashes.

I'm not sure what you mean here?

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants