Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fltk: build with cmake and fix license #112307

Closed
wants to merge 1 commit into from
Closed

fltk: build with cmake and fix license #112307

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2021

Motivation for this change

I need the .cmake files in the fltk output to update giada and switch to its new CMake build system.
Also combined 1.3 and 1.4 versions as they were very similar.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from veprbl February 7, 2021 16:05
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112307 run on x86_64-darwin 1

6 packages marked as broken and skipped:
  • crowbar
  • eureka-editor
  • giada
  • octave-jit
  • rtl_433
  • welle-io
1 package failed to build and already failed to build on hydra master:
  • octaveFull: log was empty
5 packages failed to build and are new build failures:
  • fltk: log https://termbin.com/c4jd
  • (fltk13): log was empty
  • gama: log was empty
  • minc_widgets: log was empty
  • octave: log was empty
1 package built:
  • fltk14

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 112307 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • hyper-haskell
  • octave-jit
16 packages failed to build:
  • bumblebee
  • crowbar
  • ensemble-chorus
  • eureka-editor
  • fltrator
  • giac-with-xcas
  • ja2-stracciatella
  • jwm-settings-manager
  • lmms
  • new-session-manager
  • posterazor
  • tigervnc
  • virtualgl
  • virtualglLib
  • xautoclick
  • yoshimi
54 packages built:
  • afterstep
  • alsaTools
  • csound
  • csound-qt
  • cubicsdr
  • dillo
  • exrdisplay
  • faust2csound
  • fldigi
  • fllog
  • flmsg
  • flpsed
  • flrig
  • fltk (fltk13)
  • fltk14
  • flwrap
  • gama
  • giada
  • gmsh
  • gqrx
  • gr-ais
  • gr-gsm
  • gr-limesdr
  • gr-osmosdr
  • limesuite
  • liquidwar
  • minc_widgets
  • mup
  • octave
  • octaveFull
  • openems
  • paulstretch
  • python37Packages.fipy
  • python37Packages.python-csxcad
  • python37Packages.python-openems
  • python37Packages.soapysdr-with-plugins
  • python38Packages.fipy
  • python38Packages.python-csxcad
  • python38Packages.python-openems
  • python38Packages.soapysdr-with-plugins
  • python39Packages.fipy
  • python39Packages.python-csxcad
  • python39Packages.python-openems
  • python39Packages.soapysdr-with-plugins
  • qradiolink
  • rakarrack
  • rtl_433
  • sdrangel
  • seaview
  • soapysdr-with-plugins
  • solfege
  • urh
  • welle-io
  • zynaddsubfx-fltk

@ghost ghost changed the title fltk: build with cmake fltk: build with cmake and fix license Feb 7, 2021
@ghost
Copy link
Author

ghost commented Feb 10, 2021

This conflicts and overlaps with #89929. Maybe better to close this and wait for that.

- combine into one generic expression
- change license to lgpl2
@ghost
Copy link
Author

ghost commented Mar 9, 2021

tigervnc doesn't build:

/nix/store/cp1sa3xxvl71cypiinw2c62i5s33chlr-binutils-2.35.1/bin/ld: /nix/store/l766aja1115g02hff4fwcbwag7rrvgrp-fltk-1.3.5/lib/libfltk.a(Fl_Window_shape.cxx.o): undefined reference to symbol 'dlsym@@GLIBC_2.2.5'

Closing in favor of #89929 since they seem to have figured it out.

@ghost ghost closed this Mar 9, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants