Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox-bin: Remove alsa/libpulseaudio dev outputs #114485

Merged
merged 1 commit into from Feb 27, 2021

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Feb 26, 2021

It doesn't seem that these make any functional difference, but they are increasing the closure size.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It doesn't seem that these make any functional difference, but they are
increasing the closure size.
@taku0
Copy link
Contributor

taku0 commented Feb 27, 2021

Those dependencies are added by the following commits (without PR?):

@garbas, are those dependencies needed today?

@taku0
Copy link
Contributor

taku0 commented Feb 27, 2021

Result of nixpkgs-review pr 114485 1

6 packages built:
  • dropbox
  • dropbox-cli
  • firefox-beta-bin-unwrapped
  • firefox-bin-unwrapped
  • firefox-devedition-bin-unwrapped
  • mate.caja-dropbox

./results/firefox-bin-unwrapped/bin/firefox can play videos on YouTube.

@adisbladis adisbladis merged commit b894f42 into NixOS:master Feb 27, 2021
@adisbladis
Copy link
Member Author

Tested all editions: firefox-bin, firefox-devedition-bin & firefox-beta-bin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants