New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove many unused inputs; amule, python27Packages.requests: mark broken; Revert "qemu: guard desktop file removal" #114768
remove many unused inputs; amule, python27Packages.requests: mark broken; Revert "qemu: guard desktop file removal" #114768
Conversation
This reverts commit e74ae54. rm -f ignores if the file exists or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for python-jq, which is the only thing I've touched in here (I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Mine was modem-manager-gui.
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 5 packages marked as broken and skipped:
1 package blacklisted:
5 packages failed to build and already failed to build on hydra master:
49 packages built:
The following issues got detected with the above build packages.
aqemu:
warning: unclear-gpl Near pkgs/applications/virtualization/aqemu/default.nix:22:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/misc/clipit/default.nix:31:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unused-argument
warning: unclear-gpl Near pkgs/tools/misc/cloud-utils/default.nix:53:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md Near pkgs/tools/misc/cloud-utils/default.nix:51:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: unused-argument
warning: unused-argument
warning: unclear-gpl Near pkgs/development/libraries/libguestfs/default.nix:90:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md Near pkgs/development/libraries/libguestfs/default.nix:90:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/applications/networking/modem-manager-gui/default.nix:60:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unused-argument
warning: unused-argument
warning: unused-argument
warning: unused-argument
warning: unnecessary-parallel-building Near pkgs/applications/virtualization/qemu/default.nix:80:3:
warning: unnecessary-parallel-building Near pkgs/applications/virtualization/qemu/default.nix:80:3:
warning: unnecessary-parallel-building Near pkgs/applications/virtualization/qemu/default.nix:80:3:
warning: unnecessary-parallel-building Near pkgs/applications/virtualization/qemu/default.nix:80:3:
warning: unnecessary-parallel-building Near pkgs/applications/virtualization/qemu/default.nix:80:3:
warning: unnecessary-parallel-building Near pkgs/applications/virtualization/qemu/default.nix:80:3:
warning: unclear-gpl Near pkgs/applications/virtualization/qtemu/default.nix:41:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing Near nixos/lib/testing-python.nix:64:7:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md Near nixos/lib/testing-python.nix:64:7:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md warning: unused-argument
warning: stale-substitute |
This is quite frankly unacceptable. Just blindly marking a package like I have a few questions:
|
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)