Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove many unused inputs; amule, python27Packages.requests: mark broken; Revert "qemu: guard desktop file removal" #114768

Merged
merged 24 commits into from Mar 2, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: pantheon The Pantheon desktop environment 6.topic: python labels Mar 1, 2021
Copy link
Member

@benley benley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for python-jq, which is the only thing I've touched in here (I think)

Copy link
Member

@alesya-h alesya-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Mine was modem-manager-gui.

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 114768 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • linuxPackages-libre.virtualbox
  • linuxPackages_hardkernel_4_14.virtualbox
  • linuxPackages_hardkernel_latest.virtualbox
  • linuxPackages_latest-libre.virtualbox
  • multibootusb
1 package blacklisted:
  • tests.nixos-functions.nixosTest-test
5 packages failed to build and already failed to build on hydra master:
  • aqemu: plain log | pretty log
  • qemu_xen: log was empty
  • (qemu_xen_4_10): log was empty
  • qemu_xen-light: log was empty
  • (qemu_xen_4_10-light): log was empty
49 packages built:
  • alpine-make-vm-image
  • clipit
  • cloud-init
  • cloud-utils
  • cot (python38Packages.cot)
  • gammastep
  • libayatana-appindicator (libayatana-appindicator-gtk3)
  • libayatana-appindicator-gtk2
  • libguestfs
  • linuxPackages.virtualbox (linuxPackages_5_4.virtualbox)
  • linuxPackages_4_14.virtualbox
  • linuxPackages_4_19.virtualbox
  • linuxPackages_4_4.virtualbox
  • linuxPackages_4_9.virtualbox
  • linuxPackages_5_10.virtualbox
  • linuxPackages_5_11.virtualbox (linuxPackages_latest.virtualbox)
  • linuxPackages_hardened.virtualbox
  • linuxPackages_latest_hardened.virtualbox
  • linuxPackages_latest_xen_dom0.virtualbox
  • linuxPackages_latest_xen_dom0_hardened.virtualbox
  • linuxPackages_lqx.virtualbox
  • linuxPackages_testing_bcachefs.virtualbox
  • linuxPackages_xen_dom0.virtualbox
  • linuxPackages_xen_dom0_hardened.virtualbox
  • linuxPackages_zen.virtualbox
  • modem-manager-gui
  • open-watcom-bin
  • out-of-tree
  • pasystray
  • python37Packages.cot
  • python37Packages.guestfs
  • python37Packages.jq
  • python38Packages.guestfs
  • python38Packages.jq
  • python39Packages.cot
  • python39Packages.guestfs
  • python39Packages.jq
  • qemu
  • qemu-utils
  • qemu_full
  • qemu_kvm
  • qemu_test
  • qtemu
  • solo5
  • vagrant
  • virtualbox
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

aqemu:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/aqemu/default.nix:22:5:

   |
22 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

clipit:

warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/applications/misc/clipit/default.nix:31:5:

   |
31 |     license     = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

cloud-init:

warning: unused-argument
Unused argument: pytest.
Near pkgs/tools/virtualization/cloud-init/default.nix:11:3:

   |
11 | , pytest
   |   ^
cloud-utils:

warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/tools/misc/cloud-utils/default.nix:53:5:

   |
53 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/tools/misc/cloud-utils/default.nix:51:3:

   |
51 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: unused-argument
Unused argument: euca2ools.
Near pkgs/tools/misc/cloud-utils/default.nix:3:30:

  |
3 | , wget, python3, qemu-utils, euca2ools
  |                              ^
cot:

warning: unused-argument
Unused argument: argcomplete.
Near pkgs/development/python-modules/cot/default.nix:2:3:

  |
2 | , argcomplete, colorlog, pyvmomi, requests, verboselogs
  |   ^

warning: unused-argument
Unused argument: pytest.
Near pkgs/development/python-modules/cot/default.nix:4:9:

  |
4 | , mock, pytest, pytest-mock, pytestCheckHook, qemu
  |         ^
libguestfs:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/development/libraries/libguestfs/default.nix:90:5:

   |
90 |     license = with licenses; [ gpl2 lgpl21 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: unclear-gpl
lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

Near pkgs/development/libraries/libguestfs/default.nix:90:5:

   |
90 |     license = with licenses; [ gpl2 lgpl21 ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_4_14.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_4_19.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_4_4.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_4_9.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_5_10.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_5_11.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_hardened.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_latest_hardened.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_latest_xen_dom0_hardened.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_latest_xen_dom0.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_lqx.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_testing_bcachefs.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_xen_dom0_hardened.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_xen_dom0.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

linuxPackages_zen.virtualbox:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virtualbox/default.nix:232:5:

    |
232 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

modem-manager-gui:

warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/applications/networking/modem-manager-gui/default.nix:60:5:

   |
60 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

python37Packages.cot:

warning: unused-argument
Unused argument: argcomplete.
Near pkgs/development/python-modules/cot/default.nix:2:3:

  |
2 | , argcomplete, colorlog, pyvmomi, requests, verboselogs
  |   ^

warning: unused-argument
Unused argument: pytest.
Near pkgs/development/python-modules/cot/default.nix:4:9:

  |
4 | , mock, pytest, pytest-mock, pytestCheckHook, qemu
  |         ^
python39Packages.cot:

warning: unused-argument
Unused argument: argcomplete.
Near pkgs/development/python-modules/cot/default.nix:2:3:

  |
2 | , argcomplete, colorlog, pyvmomi, requests, verboselogs
  |   ^

warning: unused-argument
Unused argument: pytest.
Near pkgs/development/python-modules/cot/default.nix:4:9:

  |
4 | , mock, pytest, pytest-mock, pytestCheckHook, qemu
  |         ^
qemu_full:

warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/applications/virtualization/qemu/default.nix:80:3:

   |
80 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

qemu_kvm:

warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/applications/virtualization/qemu/default.nix:80:3:

   |
80 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

qemu:

warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/applications/virtualization/qemu/default.nix:80:3:

   |
80 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

qemu_test:

warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/applications/virtualization/qemu/default.nix:80:3:

   |
80 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

qemu_xen-light:

warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/applications/virtualization/qemu/default.nix:80:3:

   |
80 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

qemu_xen:

warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/applications/virtualization/qemu/default.nix:80:3:

   |
80 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

qtemu:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/qtemu/default.nix:41:5:

   |
41 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: unused-argument
Unused argument: makeWrapper.
Near pkgs/applications/virtualization/qtemu/default.nix:1:72:

  |
1 | { lib, mkDerivation, fetchFromGitLab, pkg-config, qmake, qtbase, qemu, makeWrapper }:
  |                                                                        ^
tests.nixos-functions.nixosTest-test:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near nixos/lib/testing-python.nix:64:7:

   |
64 |       buildCommand =
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: license-missing
Package is missing a license

Near nixos/lib/testing-python.nix:64:7:

   |
64 |       buildCommand =
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

vagrant:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/development/tools/vagrant/default.nix:2:62:

  |
2 | , libguestfs, qemu, writeText, withLibvirt ? stdenv.isLinux, fetchpatch
  |                                                              ^
virtualboxHeadless:

warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'PSHCLFORMATDATA' doesn't match anything in file 'src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc-x11-stubs.cpp'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

@SuperSandro2000 SuperSandro2000 merged commit c1d529d into NixOS:master Mar 2, 2021
@SuperSandro2000 SuperSandro2000 deleted the fix-collection19 branch March 2, 2021 15:59
@adisbladis
Copy link
Member

@SuperSandro2000

This is quite frankly unacceptable. Just blindly marking a package like python2Packages.requests as broken needs a very thorough explanation and discussion.
Bundling it up with a bunch of other seemingly unrelated stuff makes it even worse. This PR should never have been merged.
You need to deal with the fallout from this.

I have a few questions:

  • Did you consider the implications of what packages you are breaking (you broke nixops for one)
  • Did you even look into actually fixing the problem instead of just sweeping it under the proverbial rug?

@adisbladis adisbladis mentioned this pull request Mar 4, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants