New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpt2tc: init at 2020-12-30 #116287
gpt2tc: init at 2020-12-30 #116287
Conversation
Result of 1 package built successfully:1 suggestion:
|
Revised. |
Revised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the project isn't hosted on a normal version control platform, but it would be nice to upstream the fixes, and then package a new version with the enhancements
buildInputs = [ | ||
(python3.withPackages (p: with p; [ numpy tensorflow ])) | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is needed at runtime, you should use a wrapProgram
passing it on the PATH before executing the program.
Otherwise this python environment will only be present during the build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The program seems to be automatically getting wrapped (the shebang gets modified)?
+#!/usr/bin/env python3 | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably be upstreamed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to email Fabrice Bellard about this.
@ofborg eval |
Motivation for this change
Program by Fabrice Bellard. Source not available.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)