Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin: add libobjc to buildInputs of pkgs.bundlerEnv #11685

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
9 participants
@LnL7
Copy link
Member

commented Dec 13, 2015

rubygems with c extensions should now work on darwin unless they need specific buildFlags

@mention-bot

This comment has been minimized.

Copy link

commented Dec 13, 2015

By analyzing the blame information on this pull request, we identified @pikajude, @cstrahan and @abbradar to be potential reviewers

@gridaphobe

View changes

pkgs/development/interpreters/ruby/bundler-env/default.nix Outdated
applyGemConfigs = oldAttrs:
let
attrs = {
buildInputs = [] ++ lib.optional stdenv.isDarwin darwin.libobjc;

This comment has been minimized.

Copy link
@gridaphobe

gridaphobe Dec 15, 2015

Contributor

This can simply be

  buildInputs = lib.optional stdenv.isDarwin darwin.libobjc;
@gridaphobe

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2015

travis appears to be failing because this patch triggers a mass-rebuild of ruby packages. I'm not sure how much work that would be for hydra.

@LnL7 LnL7 force-pushed the LnL7:darwin-rubygems-libobjc branch to 9a59517 Jan 8, 2016

@zimbatm

This comment has been minimized.

Copy link
Member

commented Feb 26, 2016

hi, is this still an issue for you ? Unfortunately I don't have a Darwin system to test this branch.

@LnL7

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2016

I'm not sure, the project I used this for now runs into an openssl issue.

@garbas

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

@LnL7 you maybe have an example how to reproduce this?

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2018

Can be closed?

@globin globin closed this Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.