openvswitch-lts: 2.5.9 -> 2.5.12

[risicle]

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2020-27827
https://nvd.nist.gov/vuln/detail/CVE-2020-35498

Someone able to test this properly?

See also #112956

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 118485 at 079dd98 run on x86_64-linux 1

1 package built successfully:

• openvswitch-lts

4 suggestions:

• warning: build-tools-in-build-inputs

  util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/os-specific/linux/openvswitch/lts.nix:23:3:

     |
  23 |   buildInputs = [ util-linux openssl libcap_ng python2 perl procps which ];
     |   ^
  

• warning: unused-argument

  Unused argument: iproute.
  Near pkgs/os-specific/linux/openvswitch/lts.nix:2:40:

    |
  2 | , procps, libcap_ng, openssl, python2, iproute , perl
    |                                        ^
  

• warning: build-tools-in-build-inputs

  which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/os-specific/linux/openvswitch/lts.nix:23:3:

     |
  23 |   buildInputs = [ util-linux openssl libcap_ng python2 perl procps which ];
     |   ^
  

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/os-specific/linux/openvswitch/lts.nix:18:15:

     |
  18 |   patches = [ ./patches/lts-ssl.patch ];
     |               ^
  

[SuperSandro2000]

ping @netixx @kmcopper

[SuperSandro2000]

@ofborg eval