Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dash: add libedit support, enable parallel building #118491

Merged
merged 3 commits into from Apr 4, 2021
Merged

dash: add libedit support, enable parallel building #118491

merged 3 commits into from Apr 4, 2021

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Apr 4, 2021

Motivation for this change

This allows running set -o emacs to get line editing in dash, which is a major usability improvement.

Closure size before: 31.6M
              after: 35.3M
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
dash: move confusing comment
ffb529a 
When the noexec patch was added, this comment should have been moved
to make it clear it referred to the Darwin patch, which was previously
the only one.
@alyssais
dash: add libedit support
1de9cd1 
This allows running set -o emacs to get line editing in dash, which is
a major usability improvement.

Closure size before: 31.6M
              after: 35.3M
@alyssais
dash: enable parallel building
91f4afd
@SuperSandro2000
Copy link
Member

@ofborg eval

SuperSandro2000
SuperSandro2000 approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ofborg approves

@alyssais alyssais merged commit 101cc90 into NixOS:master Apr 4, 2021
@alyssais alyssais deleted the dash branch April 6, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @SuperSandro2000