Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] place-cursor-at: init at 1.0.1 #118845

Conversation

unclechu
Copy link
Member

@unclechu unclechu commented Apr 8, 2021

Motivation for this change

In current master it was just picked from haskellPackages in top-level packages (see #118598). But in release-20.09 this package wasn’t picked from Hackage yet (see failed attempt to backport #118626). So this MR just directly pins the version from the source repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@unclechu
Copy link
Member Author

unclechu commented Apr 8, 2021

@SuperSandro2000 Please read the description. It is impossible to simply backport it (see #118626).

@unclechu unclechu force-pushed the add-place-cursor-at-to-release-20.09 branch from f1f6d65 to cd5729d Compare April 8, 2021 21:53
@sternenseemann sternenseemann changed the title Add “place-cursor-at” package to “release-20.09” [20.09] place-cursor-at: init at 1.0.1 Apr 9, 2021
@unclechu
Copy link
Member Author

@sternenseemann Are there any more changes I’m supposed to make? What would be an acceptance criteria?

@sternenseemann
Copy link
Member

can you wrap the mkDerivation with justStaticExecutables? Should save on runtime closure possibly.

@unclechu
Copy link
Member Author

@sternenseemann for some reason it fails:

nix run -I nixpkgs=. nixpkgs.place-cursor-at -c place-cursor-at
error: anonymous function at .../nixpkgs/pkgs/development/haskell-modules/generic-builder.nix:13:1 called with unexpected argument 'mkDerivation', at .../nixpkgs/lib/customisation.nix:69:16

I just took the flags that justStaticExecutables sets and added them to the derivation. Would this be okay?

@sternenseemann
Copy link
Member

Sure, doesn't really matter that much for this backport. Can you squash the commits?

@unclechu unclechu force-pushed the add-place-cursor-at-to-release-20.09 branch from 817071c to 8aebe3d Compare April 15, 2021 16:47
@unclechu
Copy link
Member Author

@sternenseemann Squashed.

@sternenseemann
Copy link
Member

Can you also adjust the commit message according to this?

To make it available in “release-20.09” as top-level package.
@unclechu unclechu force-pushed the add-place-cursor-at-to-release-20.09 branch from 8aebe3d to fa68ac7 Compare April 15, 2021 20:18
@unclechu
Copy link
Member Author

@sternenseemann Done

@sternenseemann sternenseemann merged commit eb47cc0 into NixOS:release-20.09 Apr 15, 2021
@unclechu unclechu deleted the add-place-cursor-at-to-release-20.09 branch April 15, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants