New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.09] place-cursor-at: init at 1.0.1 #118845
[20.09] place-cursor-at: init at 1.0.1 #118845
Conversation
Please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes to backport a commit. |
@SuperSandro2000 Please read the description. It is impossible to simply backport it (see #118626). |
f1f6d65
to
cd5729d
Compare
@sternenseemann Are there any more changes I’m supposed to make? What would be an acceptance criteria? |
can you wrap the mkDerivation with justStaticExecutables? Should save on runtime closure possibly. |
@sternenseemann for some reason it fails: nix run -I nixpkgs=. nixpkgs.place-cursor-at -c place-cursor-at
I just took the flags that |
Sure, doesn't really matter that much for this backport. Can you squash the commits? |
817071c
to
8aebe3d
Compare
@sternenseemann Squashed. |
Can you also adjust the commit message according to this? |
To make it available in “release-20.09” as top-level package.
8aebe3d
to
fa68ac7
Compare
@sternenseemann Done |
Motivation for this change
In current
master
it was just picked fromhaskellPackages
in top-level packages (see #118598). But inrelease-20.09
this package wasn’t picked from Hackage yet (see failed attempt to backport #118626). So this MR just directly pins the version from the source repo.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)