Skip to content

Unbreak servant-docs - #120026

Closed
magthe wants to merge 1 commit into
NixOS:haskell-updatesfrom
magthe:haskell-updates
Closed

Unbreak servant-docs#120026
magthe wants to merge 1 commit into
NixOS:haskell-updatesfrom
magthe:haskell-updates

Conversation

@magthe

@magthe magthe commented Apr 21, 2021

Copy link
Copy Markdown
Contributor
Motivation for this change

It's a useful package and it builds as is without any overrides.

Things done

Built locally using nix-build -A haskellPackages.servant-docs --arg config '{ allowBroken = true; }' without issues.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions Bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 21, 2021
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 21, 2021
@sternenseemann

Copy link
Copy Markdown
Member

Thank you! I've merged your commit as cb97f4a (just reworded the message to fit the guideline). It'll be merged with #119652.

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants