Skip to content

configuration-ghc-9.0.x.nix: patch newer alex#120535

Merged
cdepillabout merged 1 commit into
NixOS:haskell-updatesfrom
vaibhavsagar:dont-patch-alex
Apr 25, 2021
Merged

configuration-ghc-9.0.x.nix: patch newer alex#120535
cdepillabout merged 1 commit into
NixOS:haskell-updatesfrom
vaibhavsagar:dont-patch-alex

Conversation

@vaibhavsagar

@vaibhavsagar vaibhavsagar commented Apr 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Member
Motivation for this change

The currently fetched patch for alex is for alex-3.2.5, and the currently bundled version is alex-3.2.6 so the patch is no longer required.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions Bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 24, 2021
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 24, 2021
@sternenseemann

sternenseemann commented Apr 24, 2021

Copy link
Copy Markdown
Member

Shouldn't we apply the patch for alex 3.2.6 then? https://gitlab.haskell.org/ghc/head.hackage/-/commit/fe192e12b88b09499d4aff0e562713e820544bd6

@vaibhavsagar vaibhavsagar changed the title configuration-ghc-9.0.x.nix: don't patch alex configuration-ghc-9.0.x.nix: patch newer alex Apr 25, 2021
@vaibhavsagar

vaibhavsagar commented Apr 25, 2021

Copy link
Copy Markdown
Member Author

Good point, I updated the PR accordingly.

@cdepillabout

cdepillabout commented Apr 25, 2021

Copy link
Copy Markdown
Member

@GrahamcOfBorg build haskell.packages.ghc901.alex

@cdepillabout

cdepillabout commented Apr 25, 2021

Copy link
Copy Markdown
Member

Looks good to me, this at least builds on x86_64 linux.

Thanks!

@cdepillabout cdepillabout merged commit 8c2e70a into NixOS:haskell-updates Apr 25, 2021
@vaibhavsagar

vaibhavsagar commented Apr 25, 2021

Copy link
Copy Markdown
Member Author

My pleasure!

@vaibhavsagar vaibhavsagar deleted the dont-patch-alex branch April 25, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout
@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaibhavsagar @sternenseemann @cdepillabout