Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration-ghc-9.0.x.nix: patch newer alex #120535

Merged
merged 1 commit into from Apr 25, 2021
Merged

configuration-ghc-9.0.x.nix: patch newer alex #120535

merged 1 commit into from Apr 25, 2021

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Apr 24, 2021 •
edited

Motivation for this change

The currently fetched patch for alex is for alex-3.2.5, and the currently bundled version is alex-3.2.6 so the patch is no longer required.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member

Shouldn't we apply the patch for alex 3.2.6 then? https://gitlab.haskell.org/ghc/head.hackage/-/commit/fe192e12b88b09499d4aff0e562713e820544bd6

@vaibhavsagar vaibhavsagar changed the title configuration-ghc-9.0.x.nix: don't patch alex configuration-ghc-9.0.x.nix: patch newer alex Apr 25, 2021
@vaibhavsagar
Copy link
Member Author

Good point, I updated the PR accordingly.

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.packages.ghc901.alex

@cdepillabout
Copy link
Member

Looks good to me, this at least builds on x86_64 linux.

Thanks!

@cdepillabout cdepillabout merged commit 8c2e70a into NixOS:haskell-updates Apr 25, 2021
@vaibhavsagar
Copy link
Member Author

My pleasure!

@vaibhavsagar vaibhavsagar deleted the dont-patch-alex branch April 25, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

@sternenseemann sternenseemann Awaiting requested review from sternenseemann sternenseemann is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @sternenseemann @cdepillabout