Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Plasma Mobile #121345

Merged
merged 12 commits into from Dec 4, 2021
Merged

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented May 1, 2021

✔️ This is pretty much ready for a final review.

Note that the first chunk of commits is in:

This includes work form #58370. Thank you @Slabity.

What this is

This includes the "basic" set of released applications from the Plasma Mobile project. In addition to the shell configuration, and the NixOS configuration to use Plasma Mobile.

Known issues

Probably not specific to Plasma Mobile

Probably specific to Plasma Mobile

  • Long clicking the wi-fi icon goes to the main settings menu (I assume it should go to some sort of network configuration utility) (unclear)
  • Forced numeric passwords!!!!! This is an upstream issue.

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NixOS/qt-kde

@samueldr
Copy link
Member Author

samueldr commented Jun 1, 2021

#125156, which only package apps is ✔️ ready for reviewing.

@samueldr samueldr force-pushed the feature/plasma-mobile branch 2 times, most recently from d48bd14 to cb521d6 Compare June 1, 2021 21:00
@samueldr
Copy link
Member Author

With this last force-push:

  • Rebased on top of current Add Plasma Mobile Gear 21.05 #125156 (plasma mobile gear 21.05).
  • Removed plasma-phone-settings as it was largely cruft and unneeded. Instead we get an (internal) malleable option set for kdeglobals/kwinrc.

@samueldr
Copy link
Member Author

samueldr commented Jul 15, 2021

(Not pushed) Tried rebasing on #127389, but the upgrade to 5.22.3 does not seem to fix the notifications issue. Night color untested.

Side-note: the issue might be different than the one for plasma5 on wayland, in the end. When reworking the kwinrc changes, I saw that by having the Placement=Maximizing value removed the notifications were not maximized (duh?). So it looks like part of the issue is that the notifications are being maximized by that config, and that something that would normally make them not maximized doesn't work with the current packaging.

@samueldr samueldr force-pushed the feature/plasma-mobile branch 2 times, most recently from 2058c9a to ddbd2ae Compare September 27, 2021 19:53
@samueldr
Copy link
Member Author

Rebased, #139459 and #139537 fixes the issues with the notification sizes.

The other two known issues noted are not breaking. The "wifi long press" issue is a supposition that the action is wrong, without actually verifying on another Plarma Mobile distro. The night light issues are untested on real hardware. Given that #117036 is closed, I figure it's more likely to be fixed. I'm still assuming if it's broken that it would be broken on "full" Plasma with Wayland.

Current status is:

@samueldr
Copy link
Member Author

samueldr commented Nov 2, 2021

Last update made the Plasma Mobile independent from Plasma Desktop. Before it required needlessly enabling all of Plasma Desktop.

I am gearing up to test on Mobile devices more in depth, since everything "generic" seems to just work at this point.

@Mindavi
Copy link
Contributor

Mindavi commented Nov 11, 2021

I tested with this configuration: Mindavi/pinephone-nixos-config@122413a

In general, seems to work ok. I can now properly login, sddm seems to work fine. It builds on the pinephone (everything that was not substituted from the cache, that is).

I did see the keyboard crash, but I don't expect this is related to packaging. In general it seems to work ok, so not sure why it crashed sometimes.

  • Using kasts, I verified that audio is working (after changing audio settings).
  • Flashlight does not seem to be working (not sure if related to packaging here).
  • For some reason, the green notification led does not go out after booting
  • Looks a lot more 'mobile' than gnome that I was running on it before
  • Bootup time ~2 mins or so
  • King's Cross (terminal emulator) looks slightly weird (letters far apart), may be an issue with King's Cross itself
  • Brightness settings work
  • Battery indicator works
  • Wifi indicator works
  • Settings app works
  • In general, icons in apps are working
  • Auto-rotate works

Have not looked at the code otherwise.

@samueldr
Copy link
Member Author

For some reason, the green notification led does not go out after booting

I don't know if there's a service that handles LEDs in Plasma Mobile. The green LED is simply the default state from Linux's initialization.

For some reason, the green notification led does not go out after booting

Could be missing fonts.

With all the hardware working (except for flashlight / notification LEDs), it's looking good I guess.

A thing to do would be checking if upstream manages LEDs, and how, and why it doesn't work if so.

@Mindavi Mindavi mentioned this pull request Nov 16, 2021
12 tasks
@Mindavi
Copy link
Contributor

Mindavi commented Nov 21, 2021

I cannot find any documentation on notification LEDs in plasma mobile, and the UI also doesn't seem to expose anything about it. So I think nothing is done with it.

I've been using this a little bit since I reviewed this, and haven't found any major issues otherwise. I think this is good to go in.

@samueldr
Copy link
Member Author

samueldr commented Dec 3, 2021

rebased, fix build issue with update to 5.23.3.

@Mindavi do you want to / can you test again?

I'll build and test again for pine64-pinephone too, but it worked with the UEFI VM.

@Mindavi
Copy link
Contributor

Mindavi commented Dec 4, 2021

I'd like to, but I gave my pinephone to a friend to try it out, they are still waiting for their librem 5. Hope they can get some experience before they get it (if ever....). I'll probably get it back somewhere in the following weeks, but didn't really plan a date or anything.

So I'll not be able to test soon, unfortunately.

@Thra11
Copy link
Member

Thra11 commented Dec 4, 2021

I can try this out on my pinephone this weekend if you'd like anything specific checking or just another person to test it (but don't feel you have to wait for my review if you feel ready to merge). It's updating now...

Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the NixOS module look good to me! 👍

@samueldr
Copy link
Member Author

samueldr commented Dec 4, 2021

@Mindavi @Thra11: I didn't need anything specific to be tested. I tried it on my own unit since this is now totally ready for merging. Another pair of eyes, one last time, would have been nice, but not required.

Thank you @ttuegel for looking!

@samueldr
Copy link
Member Author

samueldr commented Dec 4, 2021

  • Verified the nixos tests for plasma5 still pass as expected

@samueldr samueldr merged commit b976947 into NixOS:master Dec 4, 2021
@samueldr samueldr deleted the feature/plasma-mobile branch December 4, 2021 20:37
@Thra11
Copy link
Member

Thra11 commented Dec 4, 2021

Seems to be basically functional, much better than last time I tested it. Lots of weird and wonderful bugs and quirks, but nothing that's obviously related to plasma mobile packaging rather than upstream bugs. Good to see this merged at last!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications and other popups are treated like "normal" windows on Plasma Wayland
5 participants