Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ulauncher: 5.9.0 -> 5.10.0 and patch #121557

Closed
wants to merge 1 commit into from

Conversation

aaronjanse
Copy link
Member

Motivation for this change

I've bundled these two changes because the latter affects code review.

Is adding clearly-labeled notes to software allowed? If not, what would be a better alternative?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aaronjanse
Copy link
Member Author

I don't like the way I patched this package. It feels inappropriate to edit someone else's error message, so I'm closing my own PR

@aaronjanse aaronjanse closed this Jun 10, 2021
@wmertens
Copy link
Contributor

FWIW, that error message would have saved me a bunch of looking stuff up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants