Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nzbhydra2: use openjdk11 #121697

Merged
merged 1 commit into from May 8, 2021
Merged

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented May 4, 2021

Motivation for this change

Use openjdk11 for nzbhydra2 ("You need Java (at least 8, at most 15)." https://github.com/theotherp/nzbhydra2/#how-to-run / theotherp/nzbhydra2#697).

With the default jre (version 16) nzbhydra2 does not start (nixos/tests/nzbhydra2.nix also fails).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/wp7ywmvmrfznqqwfyrh61rjh6qp9qjmz-nzbhydra2-3.13.2	 1528118504 (before)
/nix/store/bc9605igp1x9a50g7iw3k0ikf0bxs1kn-nzbhydra2-3.13.2	 1339522568

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

Copy link
Contributor

@danielfullmer danielfullmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needed for ZHF #122042

@SuperSandro2000 SuperSandro2000 merged commit 540680f into NixOS:master May 8, 2021
@jojosch jojosch deleted the nzbhydra2-jre branch May 8, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants