Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pydicom: disable flaky test on darwin #123847

Merged
merged 1 commit into from May 22, 2021
Merged

python3Packages.pydicom: disable flaky test on darwin #123847

merged 1 commit into from May 22, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 21, 2021

Motivation for this change

ZHF #122042

I invite anyone with a darwin machine to please try and reproduce hydra's failure https://nix-cache.s3.amazonaws.com/log/rn0cjj0hjdv2gl2g04kd587piszd3l52-python3.8-pydicom-2.1.2.drv on current master. I am unable to reproduce it on macos 10.15. Sandbox enabled, sandbox disabled, 馃し

The failure is also "just" the lack of a file modification warning (though yes, I realize the importance of paranoia around DICOM implementations).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 21, 2021
@ofborg ofborg bot requested a review from bcdarwin May 21, 2021 00:21
jonringer
jonringer approved these changes May 22, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 123847 run on x86_64-linux 1

@jonringer jonringer merged commit 7968281 into NixOS:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer