Skip to content

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Jun 9, 2021

Motivation for this change

I need this binary so I searched and found this article: https://discourse.nixos.org/t/what-is-the-right-way-to-install-symfony-cli/12845

I just updated the version and the checksum, and everything works.

Credits to the original author.

This package is a proprietary package, no sources are available.

Things done

Provide a new package

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 9, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-is-the-right-way-to-install-symfony-cli/12845/7

@drupol drupol marked this pull request as ready for review June 9, 2021 13:12
@jojosch
Copy link
Member

jojosch commented Jun 9, 2021

Have built the CLI locally and it seems to work (don't have a Symfony Cloud Account so cannot test that portion). Tested a local symfony application with symfony server:start - it did pickup the php executable from my PATH and ran the application fine.

Reviewed points
  • package build on x86_64-linux
  • executables tested on x86_64-linux
Possible improvements
Comments
  • the commit title should be in the format "(pkg-name | nixos/): (from -> to | init at version | refactor | etc)" so "symfony-cli: init at 4.25.2"

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jun 9, 2021
@drupol drupol changed the title Add Symfony CLI package. symfony-cli: init at 4.25.2 Jun 9, 2021
@drupol drupol force-pushed the feature/add-symfony-cli branch 2 times, most recently from 157e201 to 77d5eea Compare June 9, 2021 15:03
Copy link
Member

@jojosch jojosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far.

@drupol drupol force-pushed the feature/add-symfony-cli branch from 77d5eea to 72ef63e Compare June 9, 2021 18:27
@drupol drupol force-pushed the feature/add-symfony-cli branch from 72ef63e to 4e1dcac Compare June 9, 2021 18:28
@SuperSandro2000 SuperSandro2000 merged commit 9e26d88 into NixOS:master Jun 10, 2021
@drupol
Copy link
Contributor Author

drupol commented Jun 10, 2021

Thanks !

@drupol drupol deleted the feature/add-symfony-cli branch June 10, 2021 08:26
@drupol drupol mentioned this pull request Jun 12, 2021
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants