Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnd: 0.13.0-beta -> 0.13.1-beta #130735

Merged
merged 1 commit into from Jul 20, 2021
Merged

lnd: 0.13.0-beta -> 0.13.1-beta #130735

merged 1 commit into from Jul 20, 2021

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jul 20, 2021

https://github.com/lightningnetwork/lnd/blob/master/docs/release-notes/release-notes-0.13.1.md

Notably the monitoring tag is now enabled by default.

Motivation for this change

New upstream version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@nixbitcoin nixbitcoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 3e75263ca766961572ed31134468594b317119b9
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiDOlIkszv4ojhh+OtgROy6La5dAFAmD2mEoACgkQtgROy6La
5dD7HQ//fJPiGX6isBO7f95MvpuV7MpiXD6ScSVF3ss4PuNX5GsZwo6sy1YNALFW
Dqb+nr/R0lvggZfcyBndZVOdrn74MyUsn1vykpskUN3nMGiB5hQQ1BbyDKsnAVH+
WSR1mM/YIFWegGHR86I6+FoTIkMc394G1sMFcsTb+ezUTxo/z+FmDL+KL4gv5F12
QBuNVkb/J+Qe7JLFnrBbwOjlJVXXqvMaEM74f/x/HTuFc3vJ6jhUMG+es22+l1yC
y6XD0F/zgryLBFJvo24JK26Fxx6FswVWDELZIDHrNLZJ92YL1fMsxoqiUhdvndnC
sJnHITcQyutV/WBW+qRcku4Ncpg5V5sacnfL5aZyDG+7ZDcn4odt4h6iEfMk4iDS
dDiDCgyJ1vzP2/PjzMnI+9eejb26iBrIqqVCrM0ddK2zxrd2arAo56IzqQms33T4
TqnGAoJxf2vt6ObdTUFvMMnb1ou9QeJ3iO6vBxTYUHkq1+hPE+jYbVgSY0fQhDeQ
qNMwHE1/9scqzZo6ohpXRThGarnUarfzEM60ShsUUEyRzF8VW1K9dDsv9SMaDcfM
uaWWwpz8o5r93DqtSVJjgqow/YF31VEQjK1kLvjr94mrjfDT+5X68ynoNmg3EdE+
4Na22Iw4XUTkIu00XX5vS/JHVDBo/Re08YU2sSM8AWyeLrD9adU=
=o4UO
-----END PGP SIGNATURE-----

@nixbitcoin
Copy link
Contributor

Tested hash with

#!/usr/bin/env nix-shell
#!nix-shell -i bash -p coreutils curl jq common-updater-scripts dotnet-sdk_3 git gnupg
set -euo pipefail

newVersion=$1

# Fetch release and GPG-verify the content hash
tmpdir=$(mktemp -d /tmp/lnd-verify-gpg.XXX)
repo=$tmpdir/repo
trap "rm -rf $tmpdir" EXIT
git clone --depth 1 --branch v${newVersion} -c advice.detachedHead=false https://github.com/lightningnetwork/lnd $repo
export GNUPGHOME=$tmpdir
# Fetch Roasbeefs's key (64-bit key ID: 372CBD7633C61696)
gpg --keyserver hkps://keyserver.ubuntu.com --recv-keys E4D85299674B2D31FAA1892E372CBD7633C61696 2> /dev/null
# Fetch Bitconner's key (64-bit key ID: E7D737B67FA592C7)
gpg --keyserver hkps://keyserver.ubuntu.com --recv-keys 9C8D61868A7C492003B2744EE7D737B67FA592C7 2> /dev/null
echo
echo "Verifying commit"
git -C $repo verify-commit HEAD
rm -rf $repo/.git
newHash=$(nix hash-path --base32 $repo)
rm -rf $tmpdir
echo $newHash

and functionality with nix-bitcoin test suite.

@prusnak prusnak merged commit f094bd5 into NixOS:master Jul 20, 2021
@mmilata mmilata deleted the lnd-0.13.1 branch July 20, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants