New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/dokuwiki: add caddy webserver support #132551
Conversation
@1000101: It seems all tests have passed now, do you think this is good now? |
Good job! I'm going to be honest as I don't want this PR to become stale - I'm currently in a rush and I'll have no access to my PC for next few weeks, so if anyone feels like testing/reviewing this, I'd be more than grateful. Otherwise, it'll take me some time to test this properly. |
Sorry to be adding more work for you. |
ac22b80
to
2d7bd60
Compare
Thanks for the info and thank you for this important work! I rebased and updated my PR. It now includes:
Works fine for me now :) |
The diff looks fine. |
I used the concept and module template from the Wordpress PR here #84446 |
The diff is harder to review properly, but it looks good. |
Motivation for this change
To be able to combine DokuWiki with other modules that are using Caddy. This concept is unfluenced by this pull request.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)