Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cups: 2.3.3 -> 2.3.3op2 #132713

Merged
merged 1 commit into from
Oct 14, 2021
Merged

cups: 2.3.3 -> 2.3.3op2 #132713

merged 1 commit into from
Oct 14, 2021

Conversation

ncfavier
Copy link
Member

@ncfavier ncfavier commented Aug 4, 2021

https://github.com/OpenPrinting/cups/releases/tag/v2.3.3op1
https://github.com/OpenPrinting/cups/releases/tag/v2.3.3op2

Switches to the new OpenPrinting fork (https://www.phoronix.com/scan.php?page=news_item&px=Apple-No-More-CUPS).

CUPS now notifies the systemd manager when it's done starting up using sd_notify (OpenPrinting/cups@e96e96b), so we can stop relying on arbitrary delays in ensure-printers.service and tests/printing.nix, which is unreliable and recently prevented the unstable channel from updating.

I've run the printing test about 10 times with no failures on x86_64-linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ncfavier
Copy link
Member Author

ncfavier commented Aug 4, 2021

@ofborg test printing

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 4, 2021
@ofborg ofborg bot requested a review from matthewbauer August 4, 2021 22:43
@ncfavier ncfavier requested review from domenkozar and edolstra August 4, 2021 22:56
@github-actions github-actions bot added 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Sep 19, 2021
@github-actions github-actions bot removed 6.topic: emacs Text editor 8.has: changelog 6.topic: qt/kde 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation This PR adds or changes documentation labels Sep 19, 2021
@github-actions github-actions bot removed 6.topic: pantheon The Pantheon desktop environment 6.topic: vim 6.topic: python labels Sep 19, 2021
@ncfavier
Copy link
Member Author

Sorry for the noise, I rebased against the wrong branch.

@onny
Copy link
Contributor

onny commented Oct 14, 2021

I really would like to see this merged. The latest two OpenPrinting releases contain a lot of bug and security fixes!

peti
peti approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good to me. Lot's of good improvements. I'd be happy to merge unless anyone objects?

@lukegb
Copy link
Contributor

lukegb commented Oct 14, 2021

Let's land this 🛬

@lukegb lukegb merged commit b4b663e into NixOS:staging Oct 14, 2021
@ncfavier
Copy link
Member Author

Thanks!

@ncfavier ncfavier deleted the cups branch October 14, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@domenkozar domenkozar Awaiting requested review from domenkozar

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncfavier @onny @lukegb @peti