[DRAFT] librewolf: init at 90.0.2 #132992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+39
to
+44
| assert stdenv.cc.isGNU; | ||
| assert with lib.strings; ( | ||
| versionAtLeast stdenv.cc.version "4.9" | ||
| && !hasPrefix "6" stdenv.cc.version | ||
| && versionOlder stdenv.cc.version "11" | ||
| ); |
There was a problem hiding this comment.
Please use meta.broken for this kind of stuff.
Comment on lines
+47
to
+50
| libPath = lib.makeLibraryPath [ | ||
| ffmpeg | ||
| libpulseaudio | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| libPath = lib.makeLibraryPath [ | |
| ffmpeg | |
| libpulseaudio | |
| ]; |
|
|
||
| preFixup = '' | ||
| gappsWrapperArgs+=( | ||
| --prefix LD_LIBRARY_PATH : "${libPath}" |
There was a problem hiding this comment.
Suggested change
| --prefix LD_LIBRARY_PATH : "${libPath}" | |
| --prefix LD_LIBRARY_PATH : "${lib.makeLibraryPath [ ffmpeg libpulseaudio ]}" |
|
|
||
| # Remove unneeded SDK data from installation | ||
| # https://forum.palemoon.org/viewtopic.php?f=37&t=26796&p=214676#p214729 | ||
| rm -rf $out/{include,share/idl,lib/palemoon-devel-${version}} |
There was a problem hiding this comment.
Suggested change
| rm -rf $out/{include,share/idl,lib/palemoon-devel-${version}} | |
| rm -r $out/{include,share/idl,lib/palemoon-devel-${version}} |
Comment on lines
+108
to
+109
| ] | ||
| ++ (with xorg; [ |
There was a problem hiding this comment.
Suggested change
| ] | |
| ++ (with xorg; [ | |
| ] ++ (with xorg; [ |
| gnum4 | ||
| perl | ||
| pkg-config | ||
| python2 |
There was a problem hiding this comment.
Do we really need to use python2?
|
I'd personally rather use firedragon. It seems to have more reasonable defaults. Surprised it hasn't been added to nixpkgs yet. |
|
i think this is done in #151439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Packaging Librewolf, a privacy oriented Firefox fork, as requested in this issue #94918 .
I created a new package since I'm unsure about integrating this as a Firefox sub-package. There are no existing Firefox forks yet, just ESR, developer and beta builds. Also the Firefox packages seems to complicated for me. Maybe we could move duplicate code into a general Gecko-browsers meta package with a future rework.
This PR is a draft. I copied the Palemoon package and trying to integrate Librewolf patches + Firefox config into this.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)