lynx: add patch for CVE-2021-38165 #133057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
reviewed
Aug 7, 2021
Referencing the mail with the patch you didn't use is confusing. Please add the correct reference. |
MatthewCroughan
force-pushed
the
lynx-CVE-2021-38165
branch
from
8f348ec
to
c542f81
Compare
mweinelt
reviewed
Aug 7, 2021
mweinelt
reviewed
Aug 7, 2021
MatthewCroughan
force-pushed
the
lynx-CVE-2021-38165
branch
from
69035a9
to
b248743
Compare
mweinelt
requested changes
Aug 7, 2021
MatthewCroughan
force-pushed
the
lynx-CVE-2021-38165
branch
from
b248743
to
3e1bcd3
Compare
mweinelt
reviewed
Aug 7, 2021
pkgs/applications/networking/browsers/lynx/CVE-2021-38165.patch
Outdated
Show resolved
Hide resolved
MatthewCroughan
force-pushed
the
lynx-CVE-2021-38165
branch
from
3e1bcd3
to
bacb518
Compare
mweinelt
reviewed
Aug 7, 2021
| @@ -22,6 +23,14 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| hardeningEnable = [ "pie" ]; | |||
|
|
|||
| patches = [ | |||
There was a problem hiding this comment.
Suggested change
| patches = [ | |
| patches = [ |
|
You seem to have added unrelated commits. |
MatthewCroughan
force-pushed
the
lynx-CVE-2021-38165
branch
from
bacb518
to
e05f96c
Compare
Co-authored-by: nixinator <33lockdown33@protonmail.com> Co-authored-by: John Bargman <darthpjb@gmail.com> Co-authored-by: Martin Weinelt <hexa@darmstadt.ccc.de>
MatthewCroughan
force-pushed
the
lynx-CVE-2021-38165
branch
from
9feddac
to
ddce0ec
Compare
|
I have rebased with the suggested changes so far and added co-authorship to @mweinelt. Thanks for the guidance! I now know how to use fetchpatch. |
|
@ofborg build lynx |
1 task
|
Successfully created backport PR #133065 for |
|
The process '/usr/bin/git' failed with exit code 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: nixinator 33lockdown33@protonmail.com
Co-authored-by: John Bargman darthpjb@gmail.com
Motivation for this change
Fixes the security vulnerability in Lynx that resulted in this meltdown on the mailing list. Code was audited by @DarthPJB
https://lists.nongnu.org/archive/html/lynx-dev/2021-08/msg00007.html
Patch Source: https://git.alpinelinux.org/aports/tree/main/lynx/CVE-2021-38165.patch
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)