adding pygame.patch #134

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

MarcWeber commented Sep 27, 2012

No description provided.

Contributor

MarcWeber commented Sep 27, 2012

This fixes breakage of #133

Member

7c6f434c commented Oct 5, 2012

Does the current state of pygame expression work?

Contributor

MarcWeber commented Oct 11, 2012

Yes - it works. It got removed by Peter within 2 hours or such. Probably I should resubmit it along with plover after having done some more testing on plover (still waiting for a new keyboard ..)

Member

viric commented Dec 27, 2012

What is this pull-request about?

Member

viric commented Dec 27, 2012

For what I understood, Marc proposed a change in #133, which was incorrect (10b3a56). Then Marc fixed it in this pull request, but Peter reverted the merge of #133 in 310c7be and then this pull request doesn't apply trivially anymore.

Member

peti commented Feb 21, 2013

The expression doesn't build after this patch has been applied. The problem is that it adds a section

patchPhase = ''
  sed -i 's@raw_input(.*@"1"@' config_unix.py
  unset patchPhase
  patchPhase
'';

to the gcovr expression, but that package doesn't contain a file called config_unix.py, so sed exits with a non-zero error code. Also, the path to the actual patch file still isn't correct. @MarcWeber, I think it would be best if you'd re-test this patch and submit a new pull request once you're sure that the change works fine.

@peti peti closed this Feb 21, 2013

the-kenny added a commit to the-kenny/nixpkgs that referenced this pull request Jul 24, 2013

Last update to emacsPackages.
This set of Emacs packages corresponds to evaluation #134 of next on
http://hydra.tarn-vedra.de. It contains 914 successfully build
packages and 102 failures (mostly invalid package declarations).

Signed-off-by: Moritz Ulrich <moritz@tarn-vedra.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment