nixos/syncthing: fix escapes interpreted in declarative config#136121
Merged
Conversation
Dash `echo` interprets backslash escapes. This causes two consecutive backslashes in JSON to turn into a single one before the string is passed to jq, resulting in a parsing error.
github-actions
Bot
added
6.topic: nixos
ncfavier
approved these changes
Aug 29, 2021
ncfavier
left a comment
ncfavier
left a comment
Member
There was a problem hiding this comment.
Thanks, now I have something to point people to when they ask why I don't like echo.
ofborg
Bot
added
10.rebuild-darwin: 0
bjornfor
approved these changes
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Dash
echointerprets backslash escapes. This causes two consecutive backslashes in JSON to turn into a single one before the string is passed tojq, resulting in a parsing error.This happened to me because I have backslashes in my folder IDs.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"