Skip to content

nixos/syncthing: fix declarative init crash on HTTPS#136122

Merged
bjornfor merged 1 commit into
NixOS:masterfrom
dermetfan:syncthing-https
Aug 31, 2021
Merged

nixos/syncthing: fix declarative init crash on HTTPS#136122
bjornfor merged 1 commit into
NixOS:masterfrom
dermetfan:syncthing-https

Conversation

@dermetfan

@dermetfan dermetfan commented Aug 29, 2021

Copy link
Copy Markdown
Member
Motivation for this change

A previous config may be present that has HTTPS for the REST API enabled.

-L is added to follow the redirect to the https:// location.
-k is added to accept Syncthing's self-signed certificate.

This happened to me during migration to declarative config.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Fits CONTRIBUTING.md.

A previous config may be present that has HTTPS for the REST API enabled.
@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 29, 2021
@dermetfan dermetfan requested a review from ncfavier August 29, 2021 20:33
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 29, 2021
@bjornfor bjornfor merged commit 1dd3bd8 into NixOS:master Aug 31, 2021
@dermetfan dermetfan deleted the syncthing-https branch August 31, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants