New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update blink and add related tool sipclients3 #136924
Conversation
Related issue about blink not running that will hopefully be fixed here: #85242 |
pkgs/applications/networking/instant-messengers/blink/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/blink/default.nix
Outdated
Show resolved
Hide resolved
0bdceda
to
3ef63b1
Compare
3ef63b1
to
2319c40
Compare
2319c40
to
4e88588
Compare
4e88588
to
4222481
Compare
pkgs/applications/networking/instant-messengers/blink/default.nix
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled is normally ordered after version.
pkgs/applications/networking/instant-messengers/blink/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/blink/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/blink/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/python3-application/default.nix
Outdated
Show resolved
Hide resolved
src = fetchFromGitHub { | ||
owner = "AGProjects"; | ||
repo = "python3-application"; | ||
rev = "8209f3334c9b603fc81509333c38909755f663db"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rev = "8209f3334c9b603fc81509333c38909755f663db"; | |
rev = version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I want a commit (specifically this one) that was made after the most recent tag, which is 3.0.3
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Than we can't tag this as the version number. Can you just fetch that commit as a patch?
Changed. |
@SuperSandro2000, thank you for the review! I committed most of the changes you requested. What remains outstanding are the issues with missing tags and/or version numbers not reflecting commits we need in the upstream repos. As I mentioned in another comment, I have contacted them about that. If upstream does not respond immediately, shall we proceed by removing reference to version numbers that are arguably misleading (IE use only the commit hashes)? |
d8b32b0
to
0bfea04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.
git rebase -i
is a powerful command which achieves this, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here
Also since you have a lot of packages being added. It might be easier for you to cherry-pick a lot of these into other PRs. Adding individual packages is a lot easier for both the reviewers and contributors |
0bfea04
to
133c376
Compare
Closed in favor of PRs for individual packages. |
Motivation for this change
Blink and sipclients3 are packaged on behalf of NGI as a Summer of Nix deliverable.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)