Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update blink and add related tool sipclients3 #136924

Closed
wants to merge 12 commits into from

Conversation

charlieshanley
Copy link
Contributor

@charlieshanley charlieshanley commented Sep 6, 2021

Motivation for this change

Blink and sipclients3 are packaged on behalf of NGI as a Summer of Nix deliverable.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@charlieshanley
Copy link
Contributor Author

Related issue about blink not running that will hopefully be fixed here: #85242

@charlieshanley charlieshanley changed the title blink: 3.2.0 -> 5.1.1 blink: 3.2.0 -> 5.1.6 Sep 6, 2021
@charlieshanley charlieshanley marked this pull request as ready for review September 7, 2021 20:35
@charlieshanley charlieshanley changed the title blink: 3.2.0 -> 5.1.6 update blink and add related tool sipclients3 Sep 9, 2021
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled is normally ordered after version.

src = fetchFromGitHub {
owner = "AGProjects";
repo = "python3-application";
rev = "8209f3334c9b603fc81509333c38909755f663db";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "8209f3334c9b603fc81509333c38909755f663db";
rev = version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I want a commit (specifically this one) that was made after the most recent tag, which is 3.0.3 .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than we can't tag this as the version number. Can you just fetch that commit as a patch?

pkgs/tools/networking/sipclients3/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/sipclients3/default.nix Outdated Show resolved Hide resolved
@charlieshanley
Copy link
Contributor Author

disabled is normally ordered after version.

Changed.

@charlieshanley
Copy link
Contributor Author

charlieshanley commented Sep 13, 2021

@SuperSandro2000, thank you for the review!

I committed most of the changes you requested. What remains outstanding are the issues with missing tags and/or version numbers not reflecting commits we need in the upstream repos.

As I mentioned in another comment, I have contacted them about that. If upstream does not respond immediately, shall we proceed by removing reference to version numbers that are arguably misleading (IE use only the commit hashes)?

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

git rebase -i is a powerful command which achieves this, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

@jonringer
Copy link
Contributor

Also since you have a lot of packages being added. It might be easier for you to cherry-pick a lot of these into other PRs. Adding individual packages is a lot easier for both the reviewers and contributors

@charlieshanley
Copy link
Contributor Author

Closed in favor of PRs for individual packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants