Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-wifi-hotspot: init at 4.4.0 #136973

Merged
merged 1 commit into from
Apr 13, 2022
Merged

linux-wifi-hotspot: init at 4.4.0 #136973

merged 1 commit into from
Apr 13, 2022

Conversation

onny
Copy link
Contributor

@onny onny commented Sep 7, 2021 •
edited by fabaff
Loading

Motivation for this change

Fixes packaging request #136480 . Adds command line and GUI tools to easily create wifi hotspots on Linux.

Fixes #136480

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@onny
Copy link
Contributor Author

onny commented Sep 7, 2021

The GUI program wihotspot depends on a running systemd service daemon create_ap.service. Is it possible to package this service file so one could start the daemon with:

systemctl start create_ap

Or should I also add a service module so one could enable it with services.create_ap.enable = true?

@aanderse
Copy link
Member

aanderse commented Sep 7, 2021

github page:

Due to unavoidable reasons I am unable to actively maintain the repository. If anyone interseted to improve this repository let me know.

Should we proceed to package?

@ilmari-lauhakangas
Copy link
Contributor

github page:

Due to unavoidable reasons I am unable to actively maintain the repository. If anyone interseted to improve this repository let me know.

Should we proceed to package?

Looks like the reasons went away on Sep 26, 2021 :)

@onny onny changed the title linux-wifi-hotspot: init at 4.0.3 [DRAFT] linux-wifi-hotspot: init at 4.4.0 Apr 9, 2022
@onny onny marked this pull request as draft April 9, 2022 18:32
@onny
Copy link
Contributor Author

onny commented Apr 9, 2022

@aanderse One of the packaged GUI applications of this program uses PolicyKit to run the backend script create_ap with root permissions. How do I package and use these polkit scripts?

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 9, 2022
@onny onny changed the title [DRAFT] linux-wifi-hotspot: init at 4.4.0 linux-wifi-hotspot: init at 4.4.0 Apr 12, 2022
@onny onny marked this pull request as ready for review April 12, 2022 10:25
@onny onny requested a review from happysalada April 12, 2022 10:28
@happysalada
Copy link
Contributor

you have a huge diff on all-packages, I'm not sure you did what you wanted.

@onny
Copy link
Contributor Author

onny commented Apr 12, 2022

The diff is gone, unfortunately I have a merge conflict for all-packaes.nix. What is the best way to solve this?

@happysalada
Copy link
Contributor

rebase on master.
It's probably just a line that was added, the conflict should be easy to solve.

@onny
Copy link
Contributor Author

onny commented Apr 13, 2022

rebase on master. It's probably just a line that was added, the conflict should be easy to solve.

Thank you, should work bow :)

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 13, 2022
@happysalada
Copy link
Contributor

Thank you for your contribution!

@happysalada happysalada merged commit ecaee94 into NixOS:master Apr 13, 2022
@onny onny mentioned this pull request Apr 13, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happysalada happysalada Awaiting requested review from happysalada

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: linux-wifi-hotspot (create_ap)
4 participants
@onny @aanderse @ilmari-lauhakangas @happysalada