Conversation
figsoda
suggested changes
Sep 16, 2021
Member
figsoda
left a comment
There was a problem hiding this comment.
package is not added to all-packages.nix, also commit message should be amber-secret: init at 0.1.1
figsoda
approved these changes
Sep 17, 2021
Member
Author
|
Thanks @figsoda for the review!
I can change that if you feel strongly. But the reason I have kept it as amber is because:
|
Member
|
fair enough |
Member
|
darwin build failed, i think you need |
Member
|
@ofborg build amber-secret |
Member
|
Result of 1 package built:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This tools allows for easily managing secrets in a repo. Tested it locally on a NixOS machine:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)