stdenv: remove isMachO helper function #138186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 488395c. Currently, `nix print-dev-env` fails to execute if this function is present, because of its use of hex literals. Until this issue (NixOS/nix#5262) is solved, we should revert this to prevent breakage.
This was referenced Sep 16, 2021
|
A couple thoughts:
We may want to consider merging straight to master instead of staging since there is no risk of breakage (the function is not used anywhere) |
I'm not really sure where the best place is to merge this tbh, I'll defer that to more knowledgable people.
Yeah, that's a good idea. Is there any way we can actually set the |
Can you use I know they work with absolute paths like EDIT: NixOS/nix#3978 |
In that case, then I'm not sure how we'd go about writing a test for this, sadly. |
You could write a VM test that copies the Unfortunately complicated :( |
|
Not a good approach IMO. Does this help at all: |
It does not: |
|
Then can try |
|
Result of 318 packages marked as broken and skipped:
39188 packages skipped due to time constraints:
292 packages built successfully:
|
11 tasks
12 tasks
dhess
added a commit
to hackworthltd/hacknix
that referenced
this pull request
Sep 21, 2021
dhess
added a commit
to hackworthltd/hacknix
that referenced
this pull request
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently,
nix print-dev-envfails to execute if this function is present, because of its use of hex literals.Until this issue (NixOS/nix#5262) is solved, we should revert this to prevent breakage.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)