Repository navigation
stdenv: remove isMachO helper function - #138186
Conversation
This reverts commit 488395c. Currently, `nix print-dev-env` fails to execute if this function is present, because of its use of hex literals. Until this issue (NixOS/nix#5262) is solved, we should revert this to prevent breakage.
|
A couple thoughts:
We may want to consider merging straight to master instead of staging since there is no risk of breakage (the function is not used anywhere) |
I'm not really sure where the best place is to merge this tbh, I'll defer that to more knowledgable people.
Yeah, that's a good idea. Is there any way we can actually set the |
Can you use I know they work with absolute paths like EDIT: NixOS/nix#3978 |
In that case, then I'm not sure how we'd go about writing a test for this, sadly. |
You could write a VM test that copies the Unfortunately complicated :( |
|
Not a good approach IMO. Does this help at all: |
It does not: |
|
Then can try |
|
Result of 318 packages marked as broken and skipped:
39188 packages skipped due to time constraints:
292 packages built successfully:
|
Motivation for this change
Currently,
nix print-dev-envfails to execute if this function is present, because of its use of hex literals.Until this issue (NixOS/nix#5262) is solved, we should revert this to prevent breakage.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)