document cargoLock.lockFileContents#138801
Merged
happysalada merged 4 commits intoNixOS:masterfrom Sep 22, 2021
dermetfan:cargo-lock-restricted
Merged
document cargoLock.lockFileContents#138801happysalada merged 4 commits intoNixOS:masterfrom dermetfan:cargo-lock-restricted
cargoLock.lockFileContents#138801happysalada merged 4 commits intoNixOS:masterfrom
dermetfan:cargo-lock-restricted
Conversation
github-actions
bot
added
6.topic: rust
dermetfan
commented
Sep 21, 2021
| cargoLock = { | ||
| lockFile = ./Cargo.lock; | ||
| } | ||
| }; |
Member
Author
There was a problem hiding this comment.
Not related but also not worth another PR
figsoda
reviewed
Sep 21, 2021
ofborg
bot
added
10.rebuild-darwin: 0
Make it more clear that the return type is a string. Co-authored-by: figsoda <figsoda@pm.me>
figsoda
approved these changes
Sep 21, 2021
happysalada
reviewed
Sep 21, 2021
dermetfan
changed the title
dermetfan
changed the title
cargoLock.lockFileContents
Do not use recursive attribute sets where not needed, it could confuse the reader.
mentioning that `Cargo.lock` cannot be patched in the `patchPhase`
dermetfan
commented
Sep 22, 2021
|
|
||
| ```nix | ||
| rustPlatform.buildRustPackage rec { | ||
| rustPlatform.buildRustPackage { |
Member
Author
There was a problem hiding this comment.
rec is not needed here and could confuse the reader. Not really related but let's keep this snippet and the new, very similar one below in sync.
Contributor
|
Thank you for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As requested in #137395 (review)
Things done