Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] onlyoffice-documentserver-bin: init at 7.0.1 #138818

Closed
wants to merge 6 commits into from

Conversation

onny
Copy link
Contributor

@onny onny commented Sep 21, 2021

Motivation for this change

Adding onlyoffice-documentserver, fixes #132815 . Package contains server binaries to run Onlyoffice-Documentserver and all of its components.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 21, 2021
pkgs/servers/onlyoffice-documentserver-bin/default.nix Outdated Show resolved Hide resolved
pkgs/servers/onlyoffice-documentserver-bin/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@onny onny changed the title onlyoffice-documentserver-bin: init at 6.4.0 [DRAFT] onlyoffice-documentserver-bin: init at 6.4.0 Sep 21, 2021
@onny onny force-pushed the onlyoffice branch 4 times, most recently from 613d97b to 647719f Compare September 23, 2021 16:10
@onny
Copy link
Contributor Author

onny commented Sep 23, 2021

@SuperSandro2000 The binary package contains an executable which is compiled by "pkg" https://github.com/zeit/pkg
I used this fix trying to make it executable on NixOS: https://github.com/brendan-hall/nixpkgs/blob/e3b313bb59f49f10970205aafd44878d35da07e7/pkgs/development/web/now-cli/default.nix
It states:

    # now is a node program packaged using zeit/pkg.
    # thus, it contains hardcoded offsets.
    # patchelf shifts these locations when it expands headers.

When I try to run the onlyoffice file, I get a slightly different error message:

$ docservice
pkg/prelude/bootstrap.js:1
204,"size":325,"isFileValue":true,"isDirectoryValue":false}��������
          ^

SyntaxError: Unexpected token :
    at new Script (vm.js:84:7)
    at readPrelude (internal/bootstrap/node.js:238:17)
    at internal/bootstrap/node.js:245:22
    at internal/bootstrap/node.js:252:8
    at startup (internal/bootstrap/node.js:253:6)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:660:3)

@onny
Copy link
Contributor Author

onny commented Sep 24, 2021

@brendan-hall

@onny
Copy link
Contributor Author

onny commented Oct 14, 2021

@tesq0 Could you help out with patching the docservice binary which is also packaged with zeit/pkg? I haven't success yet with the patch-function unity3d is using :(

@genofire
Copy link
Contributor

Thanks you for the work, but is it possible to build from source? For later patches e.g.

@onny onny marked this pull request as draft March 21, 2022 12:36
@onny onny changed the title [DRAFT] onlyoffice-documentserver-bin: init at 6.4.0 [DRAFT] onlyoffice-documentserver-bin: init at 7.0.0 Apr 16, 2022
@onny onny changed the title [DRAFT] onlyoffice-documentserver-bin: init at 7.0.0 [DRAFT] onlyoffice-documentserver-bin: init at 7.0.1 Apr 16, 2022
@onny onny closed this Jul 18, 2022
@onny onny deleted the onlyoffice branch July 18, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging request: onlyoffice-documentserver
3 participants