Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foo2zjs: add hbpl1 printers support #139763

Merged
merged 1 commit into from
Nov 20, 2021
Merged

foo2zjs: add hbpl1 printers support #139763

merged 1 commit into from
Nov 20, 2021

Conversation

onny
Copy link
Contributor

@onny onny commented Sep 28, 2021

Motivation for this change

This PR adds a patch to add hbpl1 printers support to foo2zjs. Following new printers will be supported by the driver:

  • Dell 1250c
  • Dell C1660w
  • Dell C1760nw
  • Epson AcuLaser C1700
  • Fuji-Xerox DocuPrint CP105b

See: https://www.dechifro.org/hbpl/ . An other patch is added which fixes compatibility.
I successfully tested the driver with Dell 1250c :)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit, raboof and 7c6f434c September 28, 2021 14:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 28, 2021
@onny onny requested a review from davidak September 30, 2021 11:22
@raboof raboof removed their request for review October 1, 2021 12:29
@onny onny requested a review from matthewbauer October 3, 2021 21:15
patches = [
./no-hardcode-fw.diff
# Support HBPL1 printers https://www.dechifro.org/hbpl/
./hbpl1.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should fetchpatch this from its homepage instead?

@ofborg ofborg bot requested a review from 7c6f434c November 20, 2021 13:37
@7c6f434c 7c6f434c merged commit 727af7b into NixOS:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants