Skip to content

pngoptimizer: init at 2.7#147442

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
syvb:init-pngoptimizer
Mar 14, 2022
Merged

pngoptimizer: init at 2.7#147442
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
syvb:init-pngoptimizer

Conversation

@syvb
Copy link
Member

@syvb syvb commented Nov 26, 2021

Motivation for this change

This packages PngOptimizer, a PNG optimization and conversion program with a terminal (pngoptimizercl) and UI (pngoptimizer) interface.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@syvb syvb force-pushed the init-pngoptimizer branch from 5a0d49f to 4088abe Compare November 26, 2021 01:11
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 26, 2021
@syvb syvb force-pushed the init-pngoptimizer branch from 4088abe to 06371f3 Compare November 26, 2021 17:31
@syvb
Copy link
Member Author

syvb commented Mar 13, 2022

Is there anything more I need to do to get this merged?

@SuperSandro2000 SuperSandro2000 merged commit 8335e40 into NixOS:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants