Vala updates 2021-12-02 #148372

bobby285271 · 2021-12-03T02:34:37Z

Motivation for this change

Bump vala 0.48 and 0.52, remove EOL version, revisit packages that are not building with latest vala.

Things done

Built on platform(s)
- x86_64-linux
- aarch64-linux
- x86_64-darwin
- aarch64-darwin
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Fits CONTRIBUTING.md.

https://gitlab.gnome.org/GNOME/vala/raw/0.48.20/NEWS

https://gitlab.gnome.org/GNOME/vala/raw/0.52.8/NEWS

bobby285271 · 2021-12-03T02:44:25Z

Vala 0.52.8

b059d72: vala_0_52: 0.52.7 → 0.52.8
https://ftp.gnome.org/pub/GNOME/sources/vala/0.52/vala-0.52.8.news
https://gitlab.gnome.org/GNOME/vala/-/compare/0.52.7...0.52.8

Various improvements and bug fixes:

codegen:
- Use CCodeConstant for member access of constant symbol
- Add and use CCodeConstantIdentifier for accessing constants
- Check required length of enum type name for GType support
- Add missing check while overriding virtual async interface methods [#852]
- Drop inconsistent space for ObjectType parameters
- Accept CCode.type attribute on parameters [#876]
- Fix CCodeUnaryExpression.write() for PREFIX_INCREMENT/PREFIX_DECREMENT
vala:
- Improve error message for invalid handler of dynamic signal
- Using SignalHandler.disconnect() is required for dynamic signals
- Check for unavailable value-type of variable initializer [#1253]
- Add [Profile] as known attribute for methods
- Report error on missing gio-2.0 package for async constructors
- Fix signals with generic return
- parser: Split out Parser.parse_switch_section_statement()
- parser: Better handling of misplaced switch sections [#1246]
genie:
- Amend text of indent and dedent for error messages [#497]
- Accept INTERR token before type arguments when parsing type [#1245]
- Properly handle plain "get" or "set" property accessors [#1248]
- "exception" is the expected string for TokenType.ERRORDOMAIN
- Accept accessibility/async modifiers on "construct" creation methods [#1235]
girparser: Accept "sealed" for transformed records and compact classes
gtkmodule: Improve error message for invalid signal element in ui-file
tests: Rename colliding test cases to avoid conflicts

Bindings:

alsa: Add more API and fix a few things
gnome-desktop-3.0: Some parameter fixes
gstreamer: Cherry-pick bindings fixes from 0.56
gstreamer-base-1.0: Some parameter fixes [#1255]
pango: Cherry-pick bindings fixes from 0.56

Vala 0.48.20

64899e8: vala_0_48: 0.48.19 → 0.48.20
https://ftp.gnome.org/pub/GNOME/sources/vala/0.48/vala-0.48.20.news
https://gitlab.gnome.org/GNOME/vala/-/compare/0.48.19...0.48.20

Various improvements and bug fixes:

codegen:
- Add type declaration for implicit temporary local variable
- Actually free data when using "remove(_all)"
  on GLib.Queue/(S)List [#1238]
- Use CCodeConstant for member access of constant symbol
- Add and use CCodeConstantIdentifier for accessing constants
- Check required length of enum type name for GType support
- Add missing check while overriding virtual async interface methods [#852]
- Drop inconsistent space for ObjectType parameters
- Accept CCode.type attribute on parameters [#876]
- Fix CCodeUnaryExpression.write() for PREFIX_INCREMENT/PREFIX_DECREMENT
vala:
- Warn about unsupported cast to void and drop it [#1070]
- Don't restrict element type of GLib.Array [#1227]
- Accept NullType as generic type argument
- Set source references of created DataType instances in OCE
- Parameter following ellipsis parameter is not allowed [#1237]
- More thorough check of ValueType and set CodeNode.error on failure
- Really check compatiblity of error types for delegate symbol
- Correctly output signature of callable throwing error
- Report error for non ErrorType in throws
- Implement CodeWriter.visit_foreach_statement()/visit_catch_clause()
- Improve error message for invalid handler of dynamic signal
- Using SignalHandler.disconnect() is required for dynamic signals
- Check for unavailable value-type of variable initializer [#1253]
- Add [Profile] as known attribute for methods
- Report error on missing gio-2.0 package for async constructors
- Fix signals with generic return
- parser: Make sure ErrorCodes are accessible as needed
- parser: Split out Parser.parse_switch_section_statement()
- parser: Better handling of misplaced switch sections [#1246]
genie:
- Amend text of indent and dedent for error messages [#497]
- Accept INTERR token before type arguments when parsing type [#1245]
- Properly handle plain "get" or "set" property accessors [#1248]
- "exception" is the expected string for TokenType.ERRORDOMAIN
- Accept accessibility/async modifiers on "construct" creation methods [#1235]
girparser: Add support for "ref_/ref_sink_/unref_function"
metadata for classes [#1233]
girparser: Accept "sealed" for transformed records and compact classes
gtkmodule: Improve error message for invalid signal element in ui-file
valadoc: Correctly format background of inline @link's [#1226]
tests: Rename colliding test cases to avoid conflicts

Bindings:

alsa: Add more API and fix a few things
gio-2.0: Unhide a few usable symbols which are marked not introspectable [#1222]
gio-2.0: Backport fixes from 0.54.2
glib-2.0: Current constants in GLib.Math are part of glib.h [#1220]
glib-2.0: Add RefString since 2.58 [#723]
gnome-desktop-3.0: Some parameter fixes
gstreamer: Cherry-pick bindings fixes from 0.56
gstreamer-base-1.0: Some parameter fixes [#1255]
gtk4: Backport fixes from 0.54.2
pango: Cherry-pick bindings fixes from 0.56

davidak

Changes look good, not tested

bobby285271 · 2021-12-03T03:19:18Z

Result of nixpkgs-review pr 148372 run on x86_64-linux 1

1 package marked as broken and skipped:

xfce.xfce4_dockbarx_plugin

4 packages built:

tootle
vala_0_48
vala_0_52
xfce.xfce4-dockbarx-plugin

See ofborg result for other platforms.

xfce.xfce4_dockbarx_plugin is an alias of xfce.xfce4-dockbarx-plugin.
For tootle, it is possible to fix build with latest vala using the patch from alpinelinux/aports@001bf1c.
For xfce.xfce4-dockbarx-plugin, it is possible to build this with latest vala without extra patches.

vala_0_44 already dropped in NixOS#127243

bobby285271 · 2021-12-03T07:16:49Z

~~pdfpc/pdfpc#594 has been fixed, give me some time to patch that.~~

Oh it is an upstream (vala) issue, so no need to patch.

bobby285271 · 2021-12-03T09:00:36Z

(Edited on 3 Dec, 2021 23:00 UTC+8)

Vala versions we have after this PR:

0.40.25 (old LTS)
0.48.20 (latest LTS)
0.52.8 (old stable)
0.54.2 (latest stable)

Package that are still building with vala_0_40:

ping - upstream has no more activity since Dec 2020, haven't found un-released fix yet
xfce.xfce4-namebar-plugin - upstream has no more activity since May 2020, and no more commit since 1.0.0

vala_0_48, vala_0_52 are not used by any packages currently.

Last cleanup PR is #127243, I didn't add alias for dropped versions following previous practice.

bobby285271 · 2021-12-03T09:52:05Z

Result of nixpkgs-review pr 148372 run on x86_64-linux 1

2 packages marked as broken and skipped:

xfce.xfce4_dockbarx_plugin
xfce.xfce4_namebar_plugin

11 packages built:

cinnamon.cinnamon-common
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.cjs
gnome.caribou
pdfpc
tootle
vala_0_48
vala_0_52
xfce.xfce4-dockbarx-plugin
xfce.xfce4-namebar-plugin

jtojnar · 2021-12-03T13:24:38Z

Caribou is no longer used by GNOME. @mkg20001 do you know what Cinnamon’s plans for it are? Maybe they could take over the upstream repo if they still intend to use it.

mkg20001 · 2021-12-03T14:27:10Z

No. The upstream repo does not mention that the library is deperacted. Though a lack of updates hints at it. Are you sure it will be/is deperacted?

Edit: Read the part with last release being 5 years ago. Created an upstream issue: linuxmint/cinnamon#10496

Has reached end of life

bobby285271 · 2021-12-03T14:52:49Z

Ooooops, actually gnome.caribou builds with latest vala with this patch... 😳

@ofborg eval

jtojnar

Great job. Personally I would just drop Vala 0.40 and mark the stuff that depends on it as broken but 🤷‍♀️

davidak · 2021-12-03T17:10:14Z

Result of nixpkgs-review pr 148372 run on x86_64-linux 1

11 packages built:

cinnamon.cinnamon-common
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.cjs
gnome.caribou
pdfpc
tootle
vala_0_48
vala_0_52
xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)
xfce.xfce4-namebar-plugin (xfce.xfce4_namebar_plugin)

davidak

Changes look good, packages build

tootle works
pdfpc starts

@bobby285271 thank you!

bobby285271 added 2 commits December 3, 2021 10:21

vala_0_48: 0.48.19 → 0.48.20

64899e8

https://gitlab.gnome.org/GNOME/vala/raw/0.48.20/NEWS

vala_0_52: 0.52.7 → 0.52.8

b059d72

https://gitlab.gnome.org/GNOME/vala/raw/0.52.8/NEWS

ofborg bot requested review from davidak, jtojnar and amaxine December 3, 2021 02:49

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 3, 2021

davidak approved these changes Dec 3, 2021

View reviewed changes

xfce.xfce4-dockbarx-plugin: build with latest vala

7c7a016

bobby285271 marked this pull request as draft December 3, 2021 04:28

github-actions bot added the 6.topic: xfce The Xfce Desktop Environment label Dec 3, 2021

bobby285271 marked this pull request as ready for review December 3, 2021 04:40

ofborg bot requested review from davidak, romildo and dtzWill December 3, 2021 04:50

tootle: fix build with latest vala

6b7a314

bobby285271 force-pushed the vala branch from be8186b to 6b7a314 Compare December 3, 2021 06:24

vala: remove disable graphviz patch for 0.44

72eff72

vala_0_44 already dropped in NixOS#127243

bobby285271 marked this pull request as draft December 3, 2021 07:17

xfce.xfce4-namebar-plugin: build with vala 0.40

d9873af

bobby285271 force-pushed the vala branch from 2761dd0 to baf05a3 Compare December 3, 2021 07:45

github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Dec 3, 2021

pdfpc: build with latest vala

68c81b1

bobby285271 force-pushed the vala branch from baf05a3 to 1561225 Compare December 3, 2021 07:45

ofborg bot added 8.has: clean-up 10.rebuild-linux: 11-100 labels Dec 3, 2021

ofborg bot removed the 10.rebuild-linux: 1-10 label Dec 3, 2021

bobby285271 marked this pull request as ready for review December 3, 2021 08:48

bobby285271 added 3 commits December 3, 2021 22:48

gnome.caribou: build with latest vala

17aff7a

vala_0_46: drop

9ef385f

Has reached end of life

vala_0_50: drop

aed209a

Has reached end of life

bobby285271 force-pushed the vala branch from 1561225 to aed209a Compare December 3, 2021 14:48

jtojnar approved these changes Dec 3, 2021

View reviewed changes

davidak approved these changes Dec 3, 2021

View reviewed changes

davidak merged commit e82ccfb into NixOS:master Dec 3, 2021

bobby285271 deleted the vala branch December 3, 2021 23:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vala updates 2021-12-02 #148372

Vala updates 2021-12-02 #148372

bobby285271 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021 •

edited

Loading

davidak left a comment

bobby285271 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021

jtojnar commented Dec 3, 2021

mkg20001 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021 •

edited

Loading

jtojnar left a comment

davidak commented Dec 3, 2021

davidak left a comment

Vala updates 2021-12-02 #148372

Vala updates 2021-12-02 #148372

Conversation

bobby285271 commented Dec 3, 2021 • edited Loading

Motivation for this change

Things done

bobby285271 commented Dec 3, 2021 • edited Loading

Vala 0.52.8

Vala 0.48.20

davidak left a comment

Choose a reason for hiding this comment

bobby285271 commented Dec 3, 2021 • edited Loading

bobby285271 commented Dec 3, 2021 • edited Loading

bobby285271 commented Dec 3, 2021 • edited Loading

bobby285271 commented Dec 3, 2021

jtojnar commented Dec 3, 2021

mkg20001 commented Dec 3, 2021 • edited Loading

bobby285271 commented Dec 3, 2021 • edited Loading

jtojnar left a comment

Choose a reason for hiding this comment

davidak commented Dec 3, 2021

davidak left a comment

Choose a reason for hiding this comment

bobby285271 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021 •

edited

Loading

mkg20001 commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 3, 2021 •

edited

Loading